This repository was archived by the owner on Nov 16, 2023. It is now read-only.
misc: introduce json/markdown formatter #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fs-eire
force-pushed
the
format-json-and-md
branch
from
36fac0d to
4bd7cf1
Compare
.vscode/settings.json
Outdated
| "tslint.configFile": "tslint.json", | ||
| "files.trimTrailingWhitespace": true, | ||
| "editor.tabSize": 2, | ||
| "editor.insertSpaces": true, | ||
| "[typescript]": { | ||
| "editor.formatOnSave": true | ||
| "editor.formatOnSave": true, | ||
| "editor.defaultFormatter": "xaver.clang-format" |
There was a problem hiding this comment.
Just to confirm -
-
It seems like the goal of this change to update vscode settings to change default formatter for ts, cpp, and jsonc files. No other logic change. Correct ?
-
How do the MD files get formatted automatically too ?
There was a problem hiding this comment.
- the default formatter for .ts and .cpp are still clang-format. this change only add formatter support for .json and .md
- the indent, spaces, empty lines and alignment of table and so on
hariharans29
approved these changes
Apr 26, 2019
|
Please make the change to include the op table generation to commit hook and merge this PR |
fs-eire
force-pushed
the
format-json-and-md
branch
from
4bd7cf1 to
8d7d8e4
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
uses Prettier and its VSCode extension to format JSON/JSONC(JSON with comments)/Markdown files.