MustBeNoExceptVoidFunctor should depend on the template type parameter to avoid being evaluated too early #9562
Conversation
…r to avoid being evaluated too early
| @@ -723,9 +723,14 @@ inline DispatchTaskImpl<TInvoke, TOnCancel>::~DispatchTaskImpl() noexcept { | |||
| } | |||
| } | |||
|
|
|||
| namespace details { | |||
asklar
added
the
AutoMerge
|
Hello @asklar! Because this pull request has the Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 10 hours, a condition that will be fulfilled in about 9 hours 37 minutes. No worries though, I will be back when the time is right! 😉 p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit 
|
any word on what versions this will be backported to? I am currently stuck on 0.64.x due to touch handling change in 0.65+ breaking our Canvas touch drawing. i was able to manually patch this change into my node_modules to keep working today, but that obviously isn't a long term solution (nor something I was to release with my app). Thanks! |
|
currently no plans to backport, this would go into 0.69; we currently don't officially support vs2022 (e.g. we don't target the vc143 package, or c++20, etc. as there is more work involved), so this is more of a future protection. |
…r to avoid being evaluated too early (microsoft#9562) * MustBeNoExceptVoidFunctor should depend on the template type parameter to avoid being evaluated too early * Change files
…arameter to avoid being evaluated too early (#9609) * MustBeNoExceptVoidFunctor should depend on the template type parameter to avoid being evaluated too early (#9562) * MustBeNoExceptVoidFunctor should depend on the template type parameter to avoid being evaluated too early * Change files * Change files Co-authored-by: Alexander Sklar <asklar@microsoft.com>
|
In case anyone else needs to integrate this temporarily, it works great for me as-is from the PR diff as I'm updating react-native-device-info module and didn't want to revert my windows VM toolchain after updating it... Here it is in patch-package form, gunzip it and drop it in |
|
Thank you Anki guy, works beautifully. |
…arameter to avoid being evaluated too early (microsoft#9609) * MustBeNoExceptVoidFunctor should depend on the template type parameter to avoid being evaluated too early (microsoft#9562) * MustBeNoExceptVoidFunctor should depend on the template type parameter to avoid being evaluated too early * Change files * Change files Co-authored-by: Alexander Sklar <asklar@microsoft.com>
…arameter to avoid being evaluated too early (#9749) * [0.68] MustBeNoExceptVoidFunctor should depend on the template type parameter to avoid being evaluated too early (#9609) * MustBeNoExceptVoidFunctor should depend on the template type parameter to avoid being evaluated too early (#9562) * MustBeNoExceptVoidFunctor should depend on the template type parameter to avoid being evaluated too early * Change files * Change files Co-authored-by: Alexander Sklar <asklar@microsoft.com> * Change files Co-authored-by: Julio César Rocha <JunielKatarn@users.noreply.github.com>
Description
Fixes #9559
Type of Change
Why
VS 17.1 introduces stricter requirements on
static_assert, which are causing a build break in the M.RN project. This fixes the previously invalid C++ code.Microsoft Reviewers: Open in CodeFlow