add missing compiler options, add a test to help prevent this in future #839
+48
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@microsoft-github-policy-service agree |
This is a more comprehensive fix than microsoft#838. Future work would involve doing the same sort of tests for non-Tristate types.
srabraham
force-pushed
the
srabraham-2025-04-30-parsingtest
branch
from
3366712 to
ff3642a
Compare
gabrielluizsf
approved these changes
May 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a more comprehensive fix than #838. Future work would involve doing the same sort of tests for non-Tristate types.
This isn't exactly a pretty test, but if we take for a given that the big switch-case needs to exist as is, then you're better off having a nasty test like this than not having it.