Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to V8 10.9 #157

Merged
1 commit merged into from
Dec 19, 2022
Merged

Update to V8 10.9 #157

1 commit merged into from
Dec 19, 2022

Conversation

tudorms
Copy link
Member

@tudorms tudorms commented Dec 16, 2022

  • Update to V8 10.9;
  • Disable iterator debugging in debug builds of ARM64 (MSVC compatibility issue);
  • Include the toolchain config (needed because we're building with c++17 while V8 / Chromium switched the defaults to c++20 already (JSI code doesn't build in c++20);
  • Also fix Ensure source links work #156 (use double backslashes for directory separators);
Microsoft Reviewers: Open in CodeFlow

@tudorms tudorms requested a review from a team as a code owner December 16, 2022 01:08
@@ -54,9 +54,13 @@ if ($Platform -like "?64") {
$gnargs += ' v8_enable_pointer_compression=true'
}

# TODO: N-API implementation of external ArrayBuffer doesn't comply with the Sandbox requirements for all memory allocations to be owned by the VM
$gnargs += ' v8_enable_sandbox=false'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$gnargs

In the latest Node-API this issue is addressed by conditional compilation for such cases.
We should bring the latest code to address it.

Copy link
Member

@vmoroz vmoroz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@ghost
Copy link

ghost commented Dec 19, 2022

Hello @tudorms!

Because this pull request has the auto merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit fd435fd into microsoft:0.65-stable Dec 19, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants