-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[sdl3-ttf] update to 3.2.0 #44153
base: master
Are you sure you want to change the base?
[sdl3-ttf] update to 3.2.0 #44153
Conversation
When testing feature
E:\sdl3-ttf\buildtrees\sdl3-ttf\install-x64-windows-dbg-out.log:
|
@MonicaLiu0311 |
All features are tested successfully in the following triplet:
|
--- a/cmake/Findplutosvg.cmake | ||
+++ b/cmake/Findplutosvg.cmake |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wait, why don't we use CMake config?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dg0yt
Sorry. I don't know the way to use CMake config.
Could you provide a sample?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
find_package/find_dependency(... CONFIG)
. Would be more than a single line change, but this is what upstream should do anyways. plutosvg needs plutovg for static library linkage.
OTOH switching to CMake config would probably leave a gap for pkg-config.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dg0yt
Thanks!
Now I understand your point.
The use of CMake config causes pkgconfig problems, as you might expect.
I don't understand how this should be fixed now, so I will do some research.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
./vcpkg x-add-version --all
and committing the result.3.2.0 is now
release
version.