Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sdl3-ttf] update to 3.2.0 #44153

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

[sdl3-ttf] update to 3.2.0 #44153

wants to merge 2 commits into from

Conversation

toge
Copy link
Contributor

@toge toge commented Mar 4, 2025

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

3.2.0 is now release version.

@MonicaLiu0311 MonicaLiu0311 added the category:port-update The issue is with a library, which is requesting update new revision label Mar 5, 2025
@MonicaLiu0311
Copy link
Contributor

When testing feature sdl3-ttf[svg], the following error occurs:

CMake Error at scripts/cmake/vcpkg_execute_build_process.cmake:134 (message):
    Command failed: E:/vcpkg/downloads/tools/cmake-3.30.1-windows/cmake-3.30.1-windows-i386/bin/cmake.exe --build . --config Debug --target install -- -v -j9
    Working Directory: E:/sdl3-ttf/buildtrees/sdl3-ttf/x64-windows-dbg
    See logs for more information:
      E:\sdl3-ttf\buildtrees\sdl3-ttf\install-x64-windows-dbg-out.log

Call Stack (most recent call first):
  installed/x64-windows/share/vcpkg-cmake/vcpkg_cmake_build.cmake:74 (vcpkg_execute_build_process)
  installed/x64-windows/share/vcpkg-cmake/vcpkg_cmake_install.cmake:16 (vcpkg_cmake_build)
  ports/sdl3-ttf/portfile.cmake:23 (vcpkg_cmake_install)
  scripts/ports.cmake:196 (include)

E:\sdl3-ttf\buildtrees\sdl3-ttf\install-x64-windows-dbg-out.log:

[4/9] C:\PROGRA~1\MICROS~1\2022\ENTERP~1\VC\Tools\MSVC\1441~1.341\bin\Hostx64\x64\cl.exe   -DBUILD_SDL -DDLL_EXPORT -DSDL_BUILD_MAJOR_VERSION=3 -DSDL_BUILD_MICRO_VERSION=0 -DSDL_BUILD_MINOR_VERSION=2 -DTTF_USE_PLUTOSVG=1 -IE:\sdl3-ttf\buildtrees\sdl3-ttf\src\ease-3.2.0-a354e35cb8.clean\include -external:IE:\sdl3-ttf\installed\x64-windows\include -external:IE:\sdl3-ttf\installed\x64-windows\include\plutosvg -external:W0 /nologo /DWIN32 /D_WINDOWS /utf-8 /MP  /MDd /Z7 /Ob0 /Od /RTC1  -MDd /W2 /showIncludes /FoCMakeFiles\SDL3_ttf-shared.dir\src\SDL_ttf.c.obj /FdCMakeFiles\SDL3_ttf-shared.dir\ /FS -c E:\sdl3-ttf\buildtrees\sdl3-ttf\src\ease-3.2.0-a354e35cb8.clean\src\SDL_ttf.c
FAILED: CMakeFiles/SDL3_ttf-shared.dir/src/SDL_ttf.c.obj 
C:\PROGRA~1\MICROS~1\2022\ENTERP~1\VC\Tools\MSVC\1441~1.341\bin\Hostx64\x64\cl.exe   -DBUILD_SDL -DDLL_EXPORT -DSDL_BUILD_MAJOR_VERSION=3 -DSDL_BUILD_MICRO_VERSION=0 -DSDL_BUILD_MINOR_VERSION=2 -DTTF_USE_PLUTOSVG=1 -IE:\sdl3-ttf\buildtrees\sdl3-ttf\src\ease-3.2.0-a354e35cb8.clean\include -external:IE:\sdl3-ttf\installed\x64-windows\include -external:IE:\sdl3-ttf\installed\x64-windows\include\plutosvg -external:W0 /nologo /DWIN32 /D_WINDOWS /utf-8 /MP  /MDd /Z7 /Ob0 /Od /RTC1  -MDd /W2 /showIncludes /FoCMakeFiles\SDL3_ttf-shared.dir\src\SDL_ttf.c.obj /FdCMakeFiles\SDL3_ttf-shared.dir\ /FS -c E:\sdl3-ttf\buildtrees\sdl3-ttf\src\ease-3.2.0-a354e35cb8.clean\src\SDL_ttf.c
E:\sdl3-ttf\installed\x64-windows\include\plutosvg\plutosvg.h(26): fatal error C1083: Cannot open include file: 'plutovg.h': No such file or directory

@MonicaLiu0311 MonicaLiu0311 marked this pull request as draft March 5, 2025 07:11
@toge
Copy link
Contributor Author

toge commented Mar 5, 2025

@MonicaLiu0311
Thanks!
I applied patch to Findplutosvg.cmake to fix it.

@toge toge marked this pull request as ready for review March 5, 2025 17:43
@MonicaLiu0311
Copy link
Contributor

All features are tested successfully in the following triplet:

x86-windows
x64-windows
x64-windows-static

@MonicaLiu0311 MonicaLiu0311 added the info:reviewed Pull Request changes follow basic guidelines label Mar 6, 2025
Comment on lines +3 to +4
--- a/cmake/Findplutosvg.cmake
+++ b/cmake/Findplutosvg.cmake
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait, why don't we use CMake config?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dg0yt
Sorry. I don't know the way to use CMake config.
Could you provide a sample?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

find_package/find_dependency(... CONFIG). Would be more than a single line change, but this is what upstream should do anyways. plutosvg needs plutovg for static library linkage.
OTOH switching to CMake config would probably leave a gap for pkg-config.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dg0yt
Thanks!
Now I understand your point.
The use of CMake config causes pkgconfig problems, as you might expect.
I don't understand how this should be fixed now, so I will do some research.

Copy link
Contributor

@JavierMatosD JavierMatosD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@toge, I'll place this in draft while you respond to @dg0yt

Thank you

@JavierMatosD JavierMatosD marked this pull request as draft March 6, 2025 18:34
@MonicaLiu0311 MonicaLiu0311 removed the info:reviewed Pull Request changes follow basic guidelines label Mar 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants