Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fxaudio] add new port #44221

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

[fxaudio] add new port #44221

wants to merge 15 commits into from

Conversation

EnzoMassyle
Copy link

@EnzoMassyle EnzoMassyle commented Mar 6, 2025

  • Changes comply with the maintainer guide.
  • The name of the port matches an existing name for this component on https://repology.org/ if possible, and/or is strongly associated with that component on search engines.
  • Optional dependencies are resolved in exactly one way. For example, if the component is built with CMake, all find_package calls are REQUIRED, are satisfied by vcpkg.json's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx.
  • The versioning scheme in vcpkg.json matches what upstream says.
  • The license declaration in vcpkg.json matches what upstream says.
  • The installed as the "copyright" file matches what upstream says.
  • The source code of the component installed comes from an authoritative source.
  • The generated "usage text" is accurate. See adding-usage for context.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is in the new port's versions file.
  • Only one version is added to each modified port's versions file.

@EnzoMassyle
Copy link
Author

On triplets x64_windows_static and x64_windows_static_md, the port I am attempting to add is building correctly. However there is a port unrelated to my port vtk that is failing to build. Is there anything I should do to fix this?

@EnzoMassyle EnzoMassyle changed the title Afx [afx] add new port Mar 7, 2025
EnzoMassyle and others added 4 commits March 6, 2025 21:33
Co-authored-by: Kai Pastor <dg0yt@darc.de>
Co-authored-by: Kai Pastor <dg0yt@darc.de>
Co-authored-by: Kai Pastor <dg0yt@darc.de>
Co-authored-by: Kai Pastor <dg0yt@darc.de>
@EnzoMassyle
Copy link
Author

Thank you for the help. I am new to contributing to open source and I really appreciate it! I am still experiencing fails on the builds x86 windows, x64 windows static and x64 windows static md.

x86 windows is failing from a powershell exit. I believe it is failing when validating the version files. Here is the important part.

D:\a_work\1\s\versions\a-\afx.json: error: afx@1.0.0 git tree f72cc6938edb4fa3836034630b51a309e7e40bc7 does not match the port directory
D:\a_work\1\s\ports\afx: note: the port directory has git tree 328ed739e64ca479a2f5640373119f4a18bf32dd
D:\a_work\1\s\ports\afx\vcpkg.json: note: if afx@1.0.0 is already published, update this file with a new version or port-version, commit it, then add the new version by running:
vcpkg x-add-version afx
git add versions
git commit -m "Update version database"
note: if afx@1.0.0 is not yet published, overwrite the previous git tree by running:
vcpkg x-add-version afx --overwrite-version
git add versions
git commit -m "Update version database"
D:\a_work\1\s\versions\baseline.json: message: afx@1.0.0 matches the current baseline
D:\a_work\1\s\ports\afx\vcpkg.json: message: all version constraints are consistent with the version database

After testing the builds on the other two, the vtk package is faliing to build which is not a dependency of my port. Again here is the part of the log where the build fails.

SUMMARY FOR x64-windows
SUCCEEDED: 52
SUMMARY FOR x64-windows-static
SUCCEEDED: 303
BUILD_FAILED: 1
CASCADED_DUE_TO_MISSING_DEPENDENCIES: 18
REGRESSIONS:
REGRESSION: vtk:x64-windows-static failed with BUILD_FAILED. If expected, add vtk:x64-windows-static=fail to D:\a_work\1\s\scripts\azure-pipelines/../ci.baseline.txt.
REGRESSION: vcpkg-ci-itk:x64-windows-static cascaded, but it is required to pass. (D:\a_work\1\s\scripts\azure-pipelines/../ci.baseline.txt).
REGRESSION: vcpkg-ci-opencv:x64-windows-static cascaded, but it is required to pass. (D:\a_work\1\s\scripts\azure-pipelines/../ci.baseline.txt).
REGRESSION: vcpkg-ci-openimageio:x64-windows-static cascaded, but it is required to pass. (D:\a_work\1\s\scripts\azure-pipelines/../ci.baseline.txt).
REGRESSION: vcpkg-ci-paraview:x64-windows-static cascaded, but it is required to pass. (D:\a_work\1\s\scripts\azure-pipelines/../ci.baseline.txt).

If you have any advice I would really appreciate it thanks!

@MonicaLiu0311 MonicaLiu0311 added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Mar 7, 2025
@MonicaLiu0311
Copy link
Contributor

PortName may need to meet the following conditions:

  • The name of the port matches an existing name for this component on https://repology.org/ if possible, and/or is strongly associated with that component on search engines.

@MonicaLiu0311 MonicaLiu0311 marked this pull request as draft March 7, 2025 07:57
@EnzoMassyle EnzoMassyle changed the title [afx] add new port [fxaudio] add new port Mar 7, 2025
@EnzoMassyle EnzoMassyle marked this pull request as ready for review March 8, 2025 03:29
@EnzoMassyle
Copy link
Author

Thank you for the help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants