-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Select interpreter is confusing when there're very few envs #19904
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
We do show a selection for the selected interpreter when the quickpick is opened. |
@jrieken We maintain the selection as @daviddossett suggested here #19904 (comment), do you suggest we add a detail property as well?
Do you suggest we remove the star icon given we already have a group for recommended?
Yes
That seems fair, currently placeholder indicates the currently selected interpreter. @luabud @daviddossett Would appreciate your opinion here as well 🙂 |
Re: showing selected interpreter — could we do something lightweight like this? FYI I summarized some quick pick guidance here: microsoft/vscode#158895 (comment) |
@daviddossett is your suggestion to drop the separators altogether? Separators are really helpful when you have multiple environments on your machine, which is a pretty common scenario for folks who work on multiple Python projects. It turned into a feature request as soon as Jupyter started using it for their kernel picker (#17944). We do highlight the currently selected interpreter by default, so I'm wondering if we can just use the "selection" as the marker of what is the currently selected interpreter (+ the info on the status bar?). Otherwise, I like David's suggestion of adding the "currently selected" text before the interpreter path. For the placeholder, we have #20129) to replace what we have with "type to filter..." instead |
Sounds good. Turns out we have the refresh icon so we cannot remove the title in favor of placeholder which says @daviddossett Do you have suggestion on how to highlight the recommended interpreter? Currently we have both a star icon and the recommended group. |
@luabud sorry for missing this. And no, I didn't mean to suggest that. I think I was just referring to this idea where we further indicate the current selection with this description/label: |
Testing #19884
/cc @daviddossett again for quick pick guidelines
The text was updated successfully, but these errors were encountered: