-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Remove UseTerminalToGetActivatedEnvVars experiment #15538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove UseTerminalToGetActivatedEnvVars experiment #15538
Conversation
@kimadeline We have a work item to restore this experiment #13071, where we'll need the code that is being removed in this PR. |
I don't think we'll reuse the code as-is, especially if we need to use a new API. The experiment will also need to be moved to Control Tower, instead of using the old experiments framework. Worst case, if we need this exact implementation, this PR can easily be reverted. |
Makes sense 👍 We should probably link this PR in the issue though as this'll be very useful. |
You already did it when you mentioned it 😁 It is also now mentioned in #15530 |
Codecov Report
@@ Coverage Diff @@
## main #15538 +/- ##
=======================================
- Coverage 65% 64% -1%
=======================================
Files 561 558 -3
Lines 27034 26870 -164
Branches 3924 3908 -16
=======================================
- Hits 17590 17417 -173
- Misses 8705 8717 +12
+ Partials 739 736 -3
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
For #15530
Basically partially reverting d788d18