Skip to content

Remove UseTerminalToGetActivatedEnvVars experiment #15538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

kimadeline
Copy link

For #15530

Basically partially reverting d788d18

@kimadeline kimadeline added no-changelog No news entry required skip package*.json package.json and package-lock.json don't both need updating labels Mar 2, 2021
@karrtikr
Copy link

karrtikr commented Mar 2, 2021

@kimadeline We have a work item to restore this experiment #13071, where we'll need the code that is being removed in this PR.

@kimadeline
Copy link
Author

I don't think we'll reuse the code as-is, especially if we need to use a new API. The experiment will also need to be moved to Control Tower, instead of using the old experiments framework. Worst case, if we need this exact implementation, this PR can easily be reverted.

@karrtikr
Copy link

karrtikr commented Mar 2, 2021

Makes sense 👍 We should probably link this PR in the issue though as this'll be very useful.

@kimadeline
Copy link
Author

We should probably link this PR in the issue though as this'll be very useful.

You already did it when you mentioned it 😁

image

It is also now mentioned in #15530

@codecov-io
Copy link

codecov-io commented Mar 3, 2021

Codecov Report

Merging #15538 (33b7e07) into main (75463af) will decrease coverage by 0%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##            main   #15538    +/-   ##
=======================================
- Coverage     65%      64%    -1%     
=======================================
  Files        561      558     -3     
  Lines      27034    26870   -164     
  Branches    3924     3908    -16     
=======================================
- Hits       17590    17417   -173     
- Misses      8705     8717    +12     
+ Partials     739      736     -3     
Impacted Files Coverage Δ
src/client/common/experiments/groups.ts 100% <ø> (ø)
src/client/interpreter/serviceRegistry.ts 100% <ø> (ø)
src/client/telemetry/index.ts 77% <ø> (ø)
src/client/common/experiments/manager.ts 85% <0%> (-11%) ⬇️
...rc/client/common/process/internal/scripts/index.ts 61% <0%> (-6%) ⬇️

@kimadeline kimadeline marked this pull request as ready for review March 3, 2021 21:12
Copy link

@ericsnowcurrently ericsnowcurrently left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kimadeline kimadeline merged commit b6c934a into microsoft:main Mar 8, 2021
@kimadeline kimadeline deleted the 15530-remove-UseTerminalToGetActivatedEnvVars branch March 8, 2021 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog No news entry required skip package*.json package.json and package-lock.json don't both need updating
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants