Skip to content

Add new getting started page #16709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 46 commits into from
Jul 26, 2021
Merged

Conversation

luabud
Copy link
Member

@luabud luabud commented Jul 17, 2021

For #16678

@luabud luabud added the skip tests Updates to tests unnecessary label Jul 17, 2021
@luabud luabud added the skip package*.json package.json and package-lock.json don't both need updating label Jul 17, 2021
@luabud luabud marked this pull request as draft July 17, 2021 00:26
@karrtikr karrtikr removed their request for review July 17, 2021 00:35
@luabud luabud requested review from kimadeline and removed request for paulacamargo25 July 17, 2021 01:27
@luabud
Copy link
Member Author

luabud commented Jul 17, 2021

@kimadeline here's the new PR 😅

@digitarald
Copy link

digitarald commented Jul 20, 2021

@luabud a few of the GIFs ballooned in size of multiple Mb.

I tried ImageOptim and it reduced the 13 Mb new_notebook.gif to 3.9 Mb – still a lot. Would be worth to cut them down further and compress.

@luabud
Copy link
Member Author

luabud commented Jul 21, 2021

@digitarald thank you so much for looking into it! I agree anything the sizes were too large, I changed many of the GIFs to be just screenshots to solve that (FYI @jmew). Now we have only 3 GIFs that altogether sum up to 1Mb, but I think we'll want to migrate to animations like you all did, so it should be a temporary thing.

@digitarald
Copy link

Looks great. I was also hoping for the smoothly animated product video look, but sadly crisp loops just get too big. I want to eventually try lightweight SVG animations, which can also add some delight.

@luabud luabud marked this pull request as ready for review July 21, 2021 21:52
@github-actions github-actions bot requested a review from karrtikr July 21, 2021 21:53
luabud and others added 8 commits July 23, 2021 12:38
Co-authored-by: Kim-Adeline Miguel <51720070+kimadeline@users.noreply.github.com>
Co-authored-by: Kim-Adeline Miguel <51720070+kimadeline@users.noreply.github.com>
Co-authored-by: Kim-Adeline Miguel <51720070+kimadeline@users.noreply.github.com>
Co-authored-by: Kim-Adeline Miguel <51720070+kimadeline@users.noreply.github.com>
@kimadeline kimadeline merged commit 0a650df into microsoft:main Jul 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip package*.json package.json and package-lock.json don't both need updating skip tests Updates to tests unnecessary
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants