Disable env activation in PowerShell using command prompt #2892
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brettcannon
suggested changes
Oct 15, 2018
news/2 Fixes/2827.md
Outdated
| @@ -0,0 +1 @@ | |||
| Disable activation of Python Environments in PowerShell by shelling into command prompt and back into PowerShell. | |||
There was a problem hiding this comment.
"Disable activation of conda environments in PowerShell."
src/client/application/diagnostics/checks/powershellActivationHack.ts
Outdated
Show resolved
Hide resolved
brettcannon
approved these changes
Oct 15, 2018
|
@brettcannon Please re-review |
brettcannon
approved these changes
Oct 15, 2018
| } | ||
| protected async waitForCommandToProcess(shell: TerminalShellType) { | ||
| // Give the command some time to complete. | ||
| // Its been observed that sending commands too early will strip some text off in VS Terminal. |
There was a problem hiding this comment.
"VS Terminal". You mean "VS Code Terminal"? Probably worth just saying "the terminal" and leave it at that.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #2732
package.jsonare pinned (e.g."1.2.3", not"^1.2.3"for the specified version)package-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed)