Skip to content

Use PythonExecutionService when possible #8338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Nov 4, 2019

Conversation

karthiknadig
Copy link
Member

For #7697

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Unit tests & system/integration tests are added/updated

@karthiknadig karthiknadig added the no-changelog No news entry required label Nov 1, 2019
@codecov-io
Copy link

codecov-io commented Nov 1, 2019

Codecov Report

Merging #8338 into master will decrease coverage by <.01%.
The diff coverage is 62.5%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8338      +/-   ##
==========================================
- Coverage   59.24%   59.24%   -0.01%     
==========================================
  Files         508      508              
  Lines       23227    23288      +61     
  Branches     3746     3777      +31     
==========================================
+ Hits        13761    13797      +36     
- Misses       8573     8595      +22     
- Partials      893      896       +3
Impacted Files Coverage Δ
src/client/testing/navigation/symbolProvider.ts 93.1% <100%> (-0.65%) ⬇️
src/client/terminals/codeExecution/helper.ts 21.27% <25%> (-0.73%) ⬇️
src/client/datascience/jupyter/jupyterDebugger.ts 8.43% <0%> (-2.04%) ⬇️
...ractive-window/interactiveWindowCommandListener.ts 59.61% <0%> (-0.69%) ⬇️
src/client/common/errors/errorUtils.ts 50% <0%> (ø) ⬆️
src/client/common/process/types.ts 100% <0%> (+12.5%) ⬆️
src/client/common/utils/async.ts 85.71% <0%> (+14.28%) ⬆️
src/client/common/process/pythonProcess.ts 95.55% <0%> (+64.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 072ccea...addbcb6. Read the comment docs.

@karthiknadig karthiknadig marked this pull request as ready for review November 2, 2019 18:46
@karthiknadig karthiknadig reopened this Nov 2, 2019
Copy link

@kimadeline kimadeline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor comments, other than that ✅

@karthiknadig
Copy link
Member Author

Re-triggering via close and re-open. since re-runs (via Checks) no longer work.

@karthiknadig karthiknadig reopened this Nov 4, 2019
@karthiknadig karthiknadig merged commit 61a6282 into microsoft:master Nov 4, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Nov 11, 2019
@karthiknadig karthiknadig deleted the 7697 branch December 27, 2019 02:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
no-changelog No news entry required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants