Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a 2 hour offset to tests to avoid being a day short after the clocks change #243194

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

a-stewart
Copy link
Contributor

Fixes #243192

After the clocks change, this time 5 days ago is only 4 days 23 hours ago, which evaluates to 4 days ago and the test fails.

This change adds a bit more margin for error, but instead testing this time (-2 hours) 5 days ago.

@connor4312 connor4312 enabled auto-merge (squash) March 11, 2025 16:22
@vs-code-engineering vs-code-engineering bot added this to the March 2025 milestone Mar 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Date.fromNowByDay.daysAgo fails after timezone change when run in US timezone
3 participants