update quick access promises to check prototype instead of instanceof #243244
+6
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating the pickerQuickAccess to check the object prototype for Promise compat. Due to how the monaco editor core uses promises, specifically the cancellation token based promise types using its own async bundle, Angular is unable to intercept these promises as ZoneAwarePromise, which causes an error whenever the monaco editor is used within the angular boundary. As this instanceof call compares with the internal Promise type for the instanceof call, but it is a ZoneAwarePromise. This prototype comparison is equivalent in all scenarios as ZoneAwarePromise is a patched promise type, and the prototype is Promise.
microsoft/monaco-editor#4372