add builtin fish arg/description/documentation to suggestion #243271
+677
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tyriar
previously requested changes
Mar 11, 2025
Comment on lines
+118
to
+121
| // Clean up the text: | ||
| // 1. Remove ANSI escape codes for bold and colors | ||
| // 2. Remove backspace sequences like 'a\bb' that cause display artifacts | ||
| const cleanHelpText = cleanupText(helpOutput); |
There was a problem hiding this comment.
You can pipe it to cat to remove the sequences:
There was a problem hiding this comment.
When I try that, it doesn't work / there are duplicate chars in the output
There was a problem hiding this comment.
this is with | cat | tr -d '\b'
There was a problem hiding this comment.
Also, since this only runs periodically, not a runtime, not sure we need to further streamline this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #241136