Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wait for diffing to stop before initializing, fix indexing #243392

Merged
merged 1 commit into from
Mar 12, 2025

Conversation

amunger
Copy link
Contributor

@amunger amunger commented Mar 12, 2025

Add a new observable to determine when the diff processing is complete instead of just waiting for the response stream to stop.

The prefixSumComputer ended up not working correctly since the cell index doesn't line up with the index within the sorted array of diffs, so just calculate on the fly.

@amunger amunger merged commit e8a73d9 into main Mar 12, 2025
8 checks passed
@amunger amunger deleted the aamunger/diffIndexing branch March 12, 2025 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants