New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Headers parsing performance optimization #366

Merged

mikel merged 1 commit into mikel:master from bogdan:headers_performance

Nov 17, 2012

+3 −5

Contributor

bogdan commented Mar 6, 2012

Among other tiny changes this PR contains the following optimization:

-        selected = select_field_for(field.name)
-
-        if selected.any? && limited_field?(field.name) 
+        if limited_field?(field.name) && (selected = select_field_for(field.name)) && selected.any?

This allows select_field_for(that is pretty slow when number of headers is high) be called only when limited_field? returns true.

About 30% performance improvement for Mail::Header.new method when there are a lot of unknown headers.


          Headers parsing performance optimization

bced96d

Owner

mikel commented Nov 17, 2012

Nice, thanks :)

mikel merged commit bced96d into mikel:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet