replace `os.Is{...}` error checks with `errors.Is(err, ...)` #83

aead · 2020-11-24T12:11:06Z

This commit replaces the error checks using the os.Is{...}
functions - e.g. os.IsExist(err) - with the more generic
errors.Is(err, ...).

In general, the os.Is{...} functions should not be used.
See: golang/go#41122

This commit replaces the error checks using the `os.Is{...}` functions - e.g. `os.IsExist(err)` - with the more generic `errors.Is(err, ...)`. In general, the `os.Is{...}` functions should not be used. See: golang/go#41122

replace os.Is{...} error checks with errors.Is(err, ...)

fd02e15

This commit replaces the error checks using the `os.Is{...}` functions - e.g. `os.IsExist(err)` - with the more generic `errors.Is(err, ...)`. In general, the `os.Is{...}` functions should not be used. See: golang/go#41122

aead requested review from harshavardhana and Alevsk November 24, 2020 12:11

harshavardhana approved these changes Nov 24, 2020

View reviewed changes

Alevsk approved these changes Nov 25, 2020

View reviewed changes

harshavardhana merged commit 5b86974 into master Nov 25, 2020

harshavardhana deleted the os-error branch November 25, 2020 02:25

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

replace `os.Is{...}` error checks with `errors.Is(err, ...)` #83

replace `os.Is{...}` error checks with `errors.Is(err, ...)` #83

aead commented Nov 24, 2020

replace os.Is{...} error checks with errors.Is(err, ...) #83

replace os.Is{...} error checks with errors.Is(err, ...) #83

Conversation

aead commented Nov 24, 2020

replace `os.Is{...}` error checks with `errors.Is(err, ...)` #83

replace `os.Is{...}` error checks with `errors.Is(err, ...)` #83