Skip to content

Allow for custom namespaces #1276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

bradrob14
Copy link

There are some cases where the XML returned via the ListObjectsEnumAsync method doesn't have the Amazon S3 namespace. This is causing the code to return an empty list every time. This is a small change to allow for custom namespaces when using S3 that don't use the Amazon namespace.

I've purposely made it opt-in, so that the original functionality is preserved.

@harshavardhana
Copy link
Member

Who is returning with custom namespaces?

@harshavardhana
Copy link
Member

Which server?

@bradrob14
Copy link
Author

Hey!

It's an on-premise solution. It actually doesn't return with a namespace at all but thought it'd be better to keep it open for custom namespaces, happy to change to a toggle if you feel that would be better 🙂

Unfortunately I can't speak to the specifics of the solution due to my place of work, but happy to talk around it as best I can

Copy link
Collaborator

@ebozduman ebozduman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bradrob14 ,

We don't accept new feature changes without one or more functional test/s added in Minio.Functional.Tests to test the new functionality for CI testing.
Besides, the current changes are not enough for the functionality to work. There are quite many references to http://s3.amazonaws.com/doc/2006-03-01/ in the code, and unfortunately they are all hard coded.
So, they all need to be fixed for the custom name space to be taken into account.

@bradrob14
Copy link
Author

Hey @ebozduman,

That's completely understandable. I'll make the needed changes when I'm able 👍

@bradrob14 bradrob14 closed this Apr 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants