[Breaking] Change match_raises to be more intuitive #419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current behaviour is unintuitive, let users know how to use the function, and test it
Change the user-defined function to better match the expectation to "match" the expected exception. Fixes mirage#418
|
The failures are:
|
MisterDA
approved these changes
Feb 12, 2025
tmcgilchrist
approved these changes
Feb 14, 2025
|
Just in case people are waiting on me merging this PR, I can't merge it :) |
|
Thanks for the fix |
samoht
added a commit
to samoht/opam-repository
that referenced
this pull request
Mar 13, 2025
CHANGES: - Add `seq`, a testable for `Seq.t` and `contramap` (mirage/alcotest#412 @xvw) - Expose the `V1.Skip` exception (mirage/alcotest#415, mirage/alcotest#416, @Khady) - BREAKING FIX: `match_raises` now expects the user-defined function to return true for expected exceptions. Previously false was interpreted as an expected exception. (mirage/alcotest#418, mirage/alcotest#419, @psafont)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know whether breaking behaviour is acceptable or not, opening to receive feedback.
I can always drop the commit with the breaking change and keep the one documenting current behaviour, suggestions on how to deal with this is welcome.
Fixes #418