reify_in_context_opt now returns reified types too
#74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JasonGross
force-pushed
the
fewer-evars
branch
from
fe351d1 to
16859dc
Compare
This means we have fewer evars hanging around. <details><summary>Timing Diff</summary> <p> ``` After | Peak Mem | File Name | Before | Peak Mem || Change || Change (mem) | % Change | % Change (mem) ---------------------------------------------------------------------------------------------------------------------------------------------------------------------- 4m07.18s | 1377416 ko | Total Time / Peak Mem | 4m07.87s | 1398624 ko || -0m00.68s || -21208 ko | -0.27% | -1.51% ---------------------------------------------------------------------------------------------------------------------------------------------------------------------- 0m54.60s | 1094484 ko | Rewriter/Rewriter/Examples/PerfTesting/LiftLetsMap.vo | 0m54.76s | 1114480 ko || -0m00.15s || -19996 ko | -0.29% | -1.79% 0m53.99s | 1377416 ko | Rewriter/Rewriter/Examples/PerfTesting/SieveOfEratosthenes.vo | 0m54.29s | 1398624 ko || -0m00.29s || -21208 ko | -0.55% | -1.51% 0m53.25s | 1076264 ko | Rewriter/Rewriter/Examples.vo | 0m53.44s | 1058980 ko || -0m00.18s || 17284 ko | -0.35% | +1.63% 0m29.49s | 922728 ko | Rewriter/Rewriter/Examples/PrefixSums.vo | 0m29.77s | 923840 ko || -0m00.28s || -1112 ko | -0.94% | -0.12% 0m23.48s | 883944 ko | Rewriter/Rewriter/Examples/PerfTesting/Plus0Tree.vo | 0m23.48s | 886408 ko || +0m00.00s || -2464 ko | +0.00% | -0.27% 0m15.90s | 734784 ko | Rewriter/Rewriter/Examples/PerfTesting/UnderLetsPlus0.vo | 0m15.82s | 734480 ko || +0m00.08s || 304 ko | +0.50% | +0.04% 0m11.88s | 637144 ko | Rewriter/Demo.vo | 0m11.85s | 637000 ko || +0m00.03s || 144 ko | +0.25% | +0.02% 0m00.93s | 475536 ko | Rewriter/Rewriter/Reify.vo | 0m00.83s | 475604 ko || +0m00.10s || -68 ko | +12.04% | -0.01% 0m00.77s | 488728 ko | Rewriter/Rewriter/AllTactics.vo | 0m00.83s | 488804 ko || -0m00.05s || -76 ko | -7.22% | -0.01% 0m00.56s | 479116 ko | Rewriter/Util/plugins/RewriterBuildRegistryImports.vo | 0m00.49s | 478992 ko || +0m00.07s || 124 ko | +14.28% | +0.02% 0m00.54s | 482260 ko | Rewriter/Rewriter/Examples/PerfTesting/Settings.vo | 0m00.56s | 482332 ko || -0m00.02s || -72 ko | -3.57% | -0.01% 0m00.51s | 480456 ko | Rewriter/Util/plugins/RewriterBuild.vo | 0m00.50s | 480636 ko || +0m00.01s || -180 ko | +2.00% | -0.03% 0m00.50s | 480132 ko | Rewriter/Util/plugins/RewriterBuildRegistry.vo | 0m00.51s | 480200 ko || -0m00.01s || -68 ko | -1.96% | -0.01% 0m00.43s | 441204 ko | Rewriter/Language/IdentifiersBasicGenerate.vo | 0m00.42s | 441280 ko || +0m00.01s || -76 ko | +2.38% | -0.01% 0m00.36s | 424856 ko | Rewriter/Language/Reify.vo | 0m00.33s | 424556 ko || +0m00.02s || 300 ko | +9.09% | +0.07% ``` </p> </details>
JasonGross
force-pushed
the
fewer-evars
branch
from
16859dc to
9785fda
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This means we have fewer evars hanging around.