Skip to content

File: Fix wrong FileStream.deinit signature #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bobcao3
Copy link

@bobcao3 bobcao3 commented Apr 23, 2025

File is a fn , not a type. Calling deinit (although there's no reason to do that) produces a compile error:

/home/bob/.cache/zig/p/libxev-0.0.0-86vtc-zkEgB7uv1i0Sa6ytJETZQi_lHJrImu9mLb9moi/src/watcher/file.zig:66:36: error: expected type 'type', found 'fn (comptime type) type'
        pub fn deinit(self: *const File) void {

Not at all an actual issue. But will confuse new users when they try to call deinit and get a surprising type error

@bobcao3 bobcao3 changed the title Fix wrong FileStream.deinit signature File: Fix wrong FileStream.deinit signature Apr 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant