Skip to content

small fixes: softcut API #1677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 19, 2023
Merged

small fixes: softcut API #1677

merged 3 commits into from
Jul 19, 2023

Conversation

dndrks
Copy link
Member

@dndrks dndrks commented May 10, 2023

softcut's voice_sync command has its arguments reversed in the API docs.

current documentation: voice_sync (src, dst, offset)
source: syncVoice(int follow, int lead, float offset)

(@tehn , this'll need a docs re-gen!)

softcut's `voice_sync` command has its arguments reversed in the API docs
@dndrks dndrks requested a review from catfact May 10, 2023 14:14
@dndrks dndrks changed the title fix: softcut.voice_sync order documentation small fixes: softcut API May 10, 2023
@dndrks
Copy link
Member Author

dndrks commented May 10, 2023

saw another typo, renamed PR!

@catfact
Copy link
Collaborator

catfact commented May 10, 2023

That's very strange, I could have sworn we already fixes these ages ago... Let's double check the order of arguments for the sync command when you actually dig sown to softcut OSC handler

Also if we're gonna update the comment for fade time, maybe correct the parameter name as well

@dndrks
Copy link
Member Author

dndrks commented May 10, 2023

@catfact , i thought so too! but both on my device and at the static API, voice_sync is listed as voice_sync (src, dst, offset).

super good call re: OSC handler! it seems like it all expects dst,src,offset. this calls this, which lands here:

void syncVoice(int follow, int lead, float offset) {
            scv[follow].cutToPos(scv[lead].getActivePosition() + offset);
        }

does that track? or am i totally reading it all wrong?

@catfact
Copy link
Collaborator

catfact commented Jul 19, 2023

huh, this never got merged? i shall merge it?

(3 months later: it tracks for me, i haven't fired the thing up in a while let alone tested this API func.)

@catfact catfact merged commit 2bad325 into main Jul 19, 2023
@catfact catfact deleted the voice_sync-order branch October 2, 2023 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants