Skip to content

feat: add lib/reflection.lua #1713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 16, 2023
Merged

feat: add lib/reflection.lua #1713

merged 3 commits into from
Oct 16, 2023

Conversation

robbielyman
Copy link
Contributor

here’s a clocked pattern recorder @dndrks and I have been kicking around for about a year now. some discussion of it exists over at #1609 . i’m not sure the discussion has fully resolved, so i’ll mark this as a draft, but if there’s interest, it would be nice to see it land soon :)

@robbielyman robbielyman marked this pull request as ready for review October 15, 2023 15:34
@robbielyman
Copy link
Contributor Author

thanks very much to @sonocircuit for some thoughtful changes and additions!

one thing I took the liberty of doing is having begin_playback just call into clock.sync directly rather than launching a new clock. since the library itself only calls begin_playback within a clock, this seems innocent, but please let me know if you think things should change @dndrks @sonocircuit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants