changed offset behaviour + bugfixes #1715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

tehn merged 1 commit into monome:main from sonocircuit:main

Oct 16, 2023

Contributor

sonocircuit commented Oct 14, 2023

following up from this #1687 discussion, here's a PR that:

changes the behaviour of the offset parameter and sets its min / max values according to the baseline value.
adresses a bug where the lfo would not run smoothly when set to free and norns clocked via midi. the clock jitter would lead to constantly changing clock.get_beat_sec() values, which is required for the phase calculation and hence led to erratic changes.
added the missing lfo_phase_ param to lfo_params_visibility().

let me know if there are any changes required.

best

s


          changed offset behaviour + bugfixes

8d7b671

dndrks approved these changes

View reviewed changes

Member

dndrks left a comment

amazing, thank you so much for these beautiful and playable adjustments, @sonocircuit !!

tehn merged commit b344418 into monome:main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet