binary triggers: allow default of '1' #1785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tehn
approved these changes
May 30, 2024
dstroud
added a commit
to dstroud/norns
that referenced
this pull request
May 30, 2024
binary triggers: allow default of '1' (monome#1785)
dstroud
added a commit
to dstroud/norns
that referenced
this pull request
Jun 18, 2024
Fixes issue introduced in monome#1785 which prevents paramset:read() from setting non-binary param values on .pset load.
tehn
pushed a commit
that referenced
this pull request
Jun 19, 2024
Fixes issue introduced in #1785 which prevents paramset:read() from setting non-binary param values on .pset load.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addresses #1784
@dansimco , I pushed these changes to my local build two weeks ago and totally spaced on PR'ing this to
main. apologies for the oversight and thank you so so much for reporting the issue!