-
Notifications
You must be signed in to change notification settings - Fork 32
fix(moonutil) *nix targets output executable files with .exe extension. #775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Consider using a platform-agnostic constant for executable extensionCategory Test case for single.exe output has inconsistent expectation on non-WindowsCategory Recommendation Documentation comment for extension handling is separated from implementationCategory |
Just to add a small point: changing When I searched online, most of the discussions I found were about compatibility. What I would like to ask is: since moonbit is a new language, is it necessary to carry over such historical conventions? cc @ftcai |
920da48
to
70bb356
Compare
Use By the way, removing cc @Young-Flash |
I don't think there are any programs that actually rely on the file extension to work; it's just that its behavior on *nix systems is a bit unusual. :) If this is not a bug but an intended feature, then I think we can go ahead and close this PR. Thanks. Edit: Additionally, if the output binary carries an For example: Although it's true that developers can specify the output filename manually using |
For testing, I think there might be a way to selectively (e.g., only in tests, by additionally using If you’re okay with it, I’d like to continue working on this PR until we find a solution that we can all agree on — either using the |
for maintainability, I prefer to keep the extension for now. thanks |
Related Issues
Type of Pull Request
Does this PR change existing behavior?
Does this PR introduce new dependencies?
Checklist: