Added onCondition and where condition for the FK delete queries #55
Conversation
|
@deadmantfa Seems like this fix works in the manner that it prevents related records from being deleted, but now deleting related records doesn't work at all. Seems like issue is caused by commenting out code in 98ab3c8 Edit: Sorry, my bad, doens't work just when you delete all related records, and is not caused by commenting code in previously mentioned commit. |
|
@sime15 Yes I agree, but that code deleted everything which was not sent it. For example if there are 5 relations and only the parent and 2 relation data was updated the next 3 would be deleted which was not by design when I as using it i.e. ver 1.1.6 I worked on that code and fixed the issue first and created a mess for myself where we lost a lot of data. Thank god for backups ;P so I commented out that code as i did not need it. But It was not there in the original PR request. This is my first time contributing with a PR. So any guidance would be great. |
📝 (README.md): update documentation for clarity and additional features ♻️ (RelationTrait.php): refactor code for better readability and maintainability ⬆️ (composer.json): update PHP version requirement and add asset-packagist repository
…sion of yii2-relation-trait package
…to avoid redundancy with actual return type declarations 🔧 (composer.json): add rector/rector as a development dependency to facilitate automated code refactoring 🔧 (rector.php): add configuration file for Rector to set up paths and code quality levels for automated refactoring
…y code structure and improve readability 🔧 (rector.php): increase type coverage, dead code, and code quality levels to 40 to enhance code robustness and maintainability
…arison for better readability and performance 🔧 (rector.php): increase type coverage, dead code, and code quality levels to 70 for stricter code analysis and improvement
…stency with other files in the project
#54 Fixes
Fixed random deletion of data due to not honouring the onCondition and where condition