Skip to content

fix: ignore invalid json responses #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 13, 2019
Merged

Conversation

nlf
Copy link
Contributor

@nlf nlf commented Aug 2, 2019

We have seen occasional responses for codecov badges returning svg even though we've requested json, this is intended to ignore non-json responses and move on anyway. I chose to return null since that's what is currently being done for non-string responses, which this is the same class of failure as.

@codecov
Copy link

codecov bot commented Aug 2, 2019

Codecov Report

Merging #29 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #29   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           6      6           
  Lines          58     61    +3     
  Branches       16     17    +1     
=====================================
+ Hits           58     61    +3
Impacted Files Coverage Δ
lib/util/shieldsIo.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9bbd0eb...72abd24. Read the comment docs.

@satazor satazor merged commit 6c69e89 into moxystudio:master Aug 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants