Fix failing build_ffi test under current nightly after rust-lang/rust#43067 landed. #126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This handles situations such as switching between the stable and nightly rustc where we might need to rebuild libmp4parse.a.out.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix failing build_ffi test under current nightly after rust-lang/rust#43067 landed.
rustc no longer prints the list of libraries for the linker by default, they must be requested with --print native-static-libs. To make life interesting, that flag is incompatible with the current stable rustc, so we need to handle both cases for now.
This fixes the failing CI builds such as https://travis-ci.org/mozilla/mp4parse-rust/jobs/302161109