Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

video/out/kitty: set display_par when drawing osd #16044

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

video/out/kitty: set display_par when drawing osd #16044

wants to merge 1 commit into from

Conversation

llyyr
Copy link
Contributor

@llyyr llyyr commented Mar 12, 2025

Fixes: #15810

@llyyr llyyr force-pushed the fix-vo-kitty branch 2 times, most recently from 8c70cc4 to bcf1a6c Compare March 12, 2025 07:14
@github-actions GitHub Actions
Copy link

Download the artifacts for this pull request:

Windows
macOS

@kasper93
Copy link
Contributor

As the original issue stated:

This fixes it, but scaling factor is not calculated properly.

I don't think this is complete fix.

@llyyr
Copy link
Contributor Author

llyyr commented Mar 12, 2025

As the original issue stated:

This fixes it, but scaling factor is not calculated properly.

I don't think this is complete fix.

Changed. Don't know what I was thinking. This should work I think

@llyyr llyyr changed the title vo_kitty: initialize display_par video/out/kitty: set display_par when drawing osd Mar 12, 2025
@kasper93 kasper93 added this to the Release v0.41.0 milestone Mar 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release v0.41.0
Development

Successfully merging this pull request may close these issues.

osd_rescale_bitmaps assert(res.display_par) fails on --vo=kitty with PGS subtitles
2 participants
@llyyr @kasper93