Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebGPURenderer: Improve performances for trackTimestamp in WebGPU #28741

Merged
merged 2 commits into from
Jun 25, 2024
Merged

WebGPURenderer: Improve performances for trackTimestamp in WebGPU #28741

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
caf862c
WebGPURenderer: Improve performances for trackTimestamp in WebGPU
RenaudRohlinger Jun 25, 2024
db39383
cleanup
RenaudRohlinger Jun 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
73 changes: 44 additions & 29 deletions examples/jsm/renderers/webgpu/WebGPUBackend.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1120,44 +1120,59 @@ class WebGPUBackend extends Backend {
const renderContextData = this.get( renderContext );

const size = 2 * BigInt64Array.BYTES_PER_ELEMENT;
const resolveBuffer = this.device.createBuffer( {
size,
usage: GPUBufferUsage.QUERY_RESOLVE | GPUBufferUsage.COPY_SRC,
} );

const resultBuffer = this.device.createBuffer( {
size,
usage: GPUBufferUsage.COPY_DST | GPUBufferUsage.MAP_READ,
} );
if ( renderContextData.currentTimestampQueryBuffers === undefined ) {

renderContextData.currentTimestampQueryBuffers = {
resolveBuffer: this.device.createBuffer({
label: 'timestamp resolve buffer',
size: size,
usage: GPUBufferUsage.QUERY_RESOLVE | GPUBufferUsage.COPY_SRC,
}),
resultBuffer: this.device.createBuffer({
label: 'timestamp result buffer',
size: size,
usage: GPUBufferUsage.COPY_DST | GPUBufferUsage.MAP_READ,
}),
isMappingPending: false,
}

}

const { resolveBuffer, resultBuffer, isMappingPending } = renderContextData.currentTimestampQueryBuffers


if ( isMappingPending === true ) return;

encoder.resolveQuerySet( renderContextData.timeStampQuerySet, 0, 2, resolveBuffer, 0 );
encoder.copyBufferToBuffer( resolveBuffer, 0, resultBuffer, 0, size );

renderContextData.currentTimestampQueryBuffer = resultBuffer;

}

async resolveTimestampAsync(renderContext, type = 'render') {
if (!this.hasFeature(GPUFeatureName.TimestampQuery) || !this.trackTimestamp) return;
async resolveTimestampAsync( renderContext, type = 'render' ) {

if ( ! this.hasFeature( GPUFeatureName.TimestampQuery ) || ! this.trackTimestamp ) return;

const renderContextData = this.get(renderContext);
const { currentTimestampQueryBuffer } = renderContextData;

if (currentTimestampQueryBuffer === undefined) return;

const buffer = currentTimestampQueryBuffer;

try {
await buffer.mapAsync(GPUMapMode.READ);
const times = new BigUint64Array(buffer.getMappedRange());
const duration = Number(times[1] - times[0]) / 1000000;
this.renderer.info.updateTimestamp(type, duration);
} catch (error) {
console.error(`Error mapping buffer: ${error}`);
// Optionally handle the error, e.g., re-queue the buffer or skip it
} finally {
buffer.unmap();
}

if ( renderContextData.currentTimestampQueryBuffers === undefined ) return;

const { resultBuffer, isMappingPending } = renderContextData.currentTimestampQueryBuffers;

if ( isMappingPending === true ) return;

renderContextData.currentTimestampQueryBuffers.isMappingPending = true;

await resultBuffer.mapAsync( GPUMapMode.READ );

const times = new BigUint64Array( resultBuffer.getMappedRange() );
const duration = Number( times[ 1 ] - times[ 0 ] ) / 1000000;

this.renderer.info.updateTimestamp( type, duration );
resultBuffer.unmap();

renderContextData.currentTimestampQueryBuffers.isMappingPending = false;

}


Expand Down