Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs:Manual lights.html typo #29756

Merged
merged 3 commits into from
Oct 29, 2024
Merged

Docs:Manual lights.html typo #29756

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e071344
Docs:Manual lights.html typo
Nokic233 Oct 28, 2024
e9ac402
Merge branch 'mrdoob:dev' into fix-typo
Nokic233 Oct 29, 2024
53831de
Docs:Manual lights.html code snippet intensity default 5
Nokic233 Oct 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions manual/en/lights.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ <h2 id="-ambientlight-"><a href="/docs/#api/en/lights/AmbientLight"><code class=
<p>And here's our code setting up lil-gui</p>
<pre class="prettyprint showlinemods notranslate lang-js" translate="no">const gui = new GUI();
gui.addColor(new ColorGUIHelper(light, 'color'), 'value').name('color');
gui.add(light, 'intensity', 0, 2, 0.01);
gui.add(light, 'intensity', 0, 5, 0.01);
</pre>
<p>And here's the result</p>
<p></p><div translate="no" class="threejs_example_container notranslate">
Expand Down Expand Up @@ -188,7 +188,7 @@ <h2 id="-hemispherelight-"><a href="/docs/#api/en/lights/HemisphereLight"><code
-gui.addColor(new ColorGUIHelper(light, 'color'), 'value').name('color');
+gui.addColor(new ColorGUIHelper(light, 'color'), 'value').name('skyColor');
+gui.addColor(new ColorGUIHelper(light, 'groundColor'), 'value').name('groundColor');
gui.add(light, 'intensity', 0, 2, 0.01);
gui.add(light, 'intensity', 0, 5, 0.01);
</pre>
<p>The result:</p>
<p></p><div translate="no" class="threejs_example_container notranslate">
Expand Down Expand Up @@ -220,7 +220,7 @@ <h2 id="-directionallight-"><a href="/docs/#api/en/lights/DirectionalLight"><cod
our GUI.</p>
<pre class="prettyprint showlinemods notranslate lang-js" translate="no">const gui = new GUI();
gui.addColor(new ColorGUIHelper(light, 'color'), 'value').name('color');
gui.add(light, 'intensity', 0, 2, 0.01);
gui.add(light, 'intensity', 0, 5, 0.01);
gui.add(light.target.position, 'x', -10, 10);
gui.add(light.target.position, 'z', -10, 10);
gui.add(light.target.position, 'y', 0, 10);
Expand Down Expand Up @@ -266,7 +266,7 @@ <h2 id="-directionallight-"><a href="/docs/#api/en/lights/DirectionalLight"><cod

const gui = new GUI();
gui.addColor(new ColorGUIHelper(light, 'color'), 'value').name('color');
gui.add(light, 'intensity', 0, 2, 0.01);
gui.add(light, 'intensity', 0, 5, 0.01);

+makeXYZGUI(gui, light.position, 'position', updateLight);
+makeXYZGUI(gui, light.target.position, 'target', updateLight);
Expand Down Expand Up @@ -319,7 +319,7 @@ <h2 id="-pointlight-"><a href="/docs/#api/en/lights/PointLight"><code class="not
<p>Let's setup the GUI so we can adjust the distance.</p>
<pre class="prettyprint showlinemods notranslate lang-js" translate="no">const gui = new GUI();
gui.addColor(new ColorGUIHelper(light, 'color'), 'value').name('color');
gui.add(light, 'intensity', 0, 2, 0.01);
gui.add(light, 'intensity', 0, 250, 1);
+gui.add(light, 'distance', 0, 40).onChange(updateLight);

makeXYZGUI(gui, light.position, 'position', updateLight);
Expand Down
6 changes: 3 additions & 3 deletions manual/examples/lights-directional.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,9 +135,9 @@
const gui = new GUI();
gui.addColor( new ColorGUIHelper( light, 'color' ), 'value' ).name( 'color' );
gui.add( light, 'intensity', 0, 5, 0.01 );
gui.add( light.target.position, 'x', - 10, 10, .01 );
gui.add( light.target.position, 'z', - 10, 10, .01 );
gui.add( light.target.position, 'y', 0, 10, .01 );
gui.add( light.target.position, 'x', - 10, 10 );
gui.add( light.target.position, 'z', - 10, 10 );
gui.add( light.target.position, 'y', 0, 10 );

}

Expand Down
10 changes: 5 additions & 5 deletions manual/fr/lights.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ <h2 id="-ambientlight-"><a href="/docs/#api/en/lights/AmbientLight"><code class=
<p>Et voici le code de configuartion de lil-gui</p>
<pre class="prettyprint showlinemods notranslate lang-js" translate="no">const gui = new GUI();
gui.addColor(new ColorGUIHelper(light, 'color'), 'value').name('color');
gui.add(light, 'intensity', 0, 2, 0.01);
gui.add(light, 'intensity', 0, 5, 0.01);
</pre>
<p>Le résultat :</p>
<p></p><div translate="no" class="threejs_example_container notranslate">
Expand Down Expand Up @@ -157,7 +157,7 @@ <h2 id="-hemispherelight-"><a href="/docs/#api/en/lights/HemisphereLight"><code
-gui.addColor(new ColorGUIHelper(light, 'color'), 'value').name('color');
+gui.addColor(new ColorGUIHelper(light, 'color'), 'value').name('skyColor');
+gui.addColor(new ColorGUIHelper(light, 'groundColor'), 'value').name('groundColor');
gui.add(light, 'intensity', 0, 2, 0.01);
gui.add(light, 'intensity', 0, 5, 0.01);
</pre>
<p>Le resultat :</p>
<p></p><div translate="no" class="threejs_example_container notranslate">
Expand All @@ -183,7 +183,7 @@ <h2 id="-directionallight-"><a href="/docs/#api/en/lights/DirectionalLight"><cod
<p>Faisons en sorte que nous puissions déplacer la cible en l'ajoutant à lil-gui.</p>
<pre class="prettyprint showlinemods notranslate lang-js" translate="no">const gui = new GUI();
gui.addColor(new ColorGUIHelper(light, 'color'), 'value').name('color');
gui.add(light, 'intensity', 0, 2, 0.01);
gui.add(light, 'intensity', 0, 5, 0.01);
gui.add(light.target.position, 'x', -10, 10);
gui.add(light.target.position, 'z', -10, 10);
gui.add(light.target.position, 'y', 0, 10);
Expand Down Expand Up @@ -218,7 +218,7 @@ <h2 id="-directionallight-"><a href="/docs/#api/en/lights/DirectionalLight"><cod

const gui = new GUI();
gui.addColor(new ColorGUIHelper(light, 'color'), 'value').name('color');
gui.add(light, 'intensity', 0, 2, 0.01);
gui.add(light, 'intensity', 0, 5, 0.01);

+makeXYZGUI(gui, light.position, 'position', updateLight);
+makeXYZGUI(gui, light.target.position, 'target', updateLight);
Expand Down Expand Up @@ -261,7 +261,7 @@ <h2 id="-pointlight-"><a href="/docs/#api/en/lights/PointLight"><code class="not
<p>Mettons à jour lil-gui pour pouvoir modifier la distance.</p>
<pre class="prettyprint showlinemods notranslate lang-js" translate="no">const gui = new GUI();
gui.addColor(new ColorGUIHelper(light, 'color'), 'value').name('color');
gui.add(light, 'intensity', 0, 2, 0.01);
gui.add(light, 'intensity', 0, 250, 1);
+gui.add(light, 'distance', 0, 40).onChange(updateLight);

makeXYZGUI(gui, light.position, 'position', updateLight);
Expand Down
10 changes: 5 additions & 5 deletions manual/ja/lights.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ <h2 id="-ambientlight-"><code class="notranslate" translate="no">AmbientLight（
<p>lil-guiの設定は以下の通りです。</p>
<pre class="prettyprint showlinemods notranslate lang-js" translate="no">const gui = new GUI();
gui.addColor(new ColorGUIHelper(light, 'color'), 'value').name('color');
gui.add(light, 'intensity', 0, 2, 0.01);
gui.add(light, 'intensity', 0, 5, 0.01);
</pre>
<p>これで以下のような結果になります。</p>
<p></p><div translate="no" class="threejs_example_container notranslate">
Expand Down Expand Up @@ -171,7 +171,7 @@ <h2 id="-hemispherelight-"><code class="notranslate" translate="no">HemisphereLi
-gui.addColor(new ColorGUIHelper(light, 'color'), 'value').name('color');
+gui.addColor(new ColorGUIHelper(light, 'color'), 'value').name('skyColor');
+gui.addColor(new ColorGUIHelper(light, 'groundColor'), 'value').name('groundColor');
gui.add(light, 'intensity', 0, 2, 0.01);
gui.add(light, 'intensity', 0, 5, 0.01);
</pre>
<p>これが結果です。</p>
<p></p><div translate="no" class="threejs_example_container notranslate">
Expand Down Expand Up @@ -199,7 +199,7 @@ <h2 id="-directionallight-"><code class="notranslate" translate="no">Directional
<p>GUIに追加してlight.targetを動かせるようにしてみましょう。</p>
<pre class="prettyprint showlinemods notranslate lang-js" translate="no">const gui = new GUI();
gui.addColor(new ColorGUIHelper(light, 'color'), 'value').name('color');
gui.add(light, 'intensity', 0, 2, 0.01);
gui.add(light, 'intensity', 0, 5, 0.01);
gui.add(light.target.position, 'x', -10, 10);
gui.add(light.target.position, 'z', -10, 10);
gui.add(light.target.position, 'y', 0, 10);
Expand Down Expand Up @@ -238,7 +238,7 @@ <h2 id="-directionallight-"><code class="notranslate" translate="no">Directional

const gui = new GUI();
gui.addColor(new ColorGUIHelper(light, 'color'), 'value').name('color');
gui.add(light, 'intensity', 0, 2, 0.01);
gui.add(light, 'intensity', 0, 5, 0.01);

+makeXYZGUI(gui, light.position, 'position', updateLight);
+makeXYZGUI(gui, light.target.position, 'target', updateLight);
Expand Down Expand Up @@ -287,7 +287,7 @@ <h2 id="-pointlight-"><code class="notranslate" translate="no">PointLight（点
<p>distanceを調整できるようにGUIを設定してみましょう。</p>
<pre class="prettyprint showlinemods notranslate lang-js" translate="no">const gui = new GUI();
gui.addColor(new ColorGUIHelper(light, 'color'), 'value').name('color');
gui.add(light, 'intensity', 0, 2, 0.01);
gui.add(light, 'intensity', 0, 250, 1);
+gui.add(light, 'distance', 0, 40).onChange(updateLight);

makeXYZGUI(gui, light.position, 'position', updateLight);
Expand Down
10 changes: 5 additions & 5 deletions manual/ko/lights.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ <h2 id="-ambientlight-"><a href="/docs/#api/ko/lights/AmbientLight"><code class=
<p>아래는 lil-gui를 만드는 코드입니다.</p>
<pre class="prettyprint showlinemods notranslate lang-js" translate="no">const gui = new GUI();
gui.addColor(new ColorGUIHelper(light, 'color'), 'value').name('color');
gui.add(light, 'intensity', 0, 2, 0.01);
gui.add(light, 'intensity', 0, 5, 0.01);
</pre>
<p>결과물은 다음과 같죠.</p>
<p></p><div translate="no" class="threejs_example_container notranslate">
Expand Down Expand Up @@ -173,7 +173,7 @@ <h2 id="-hemispherelight-"><a href="/docs/#api/ko/lights/HemisphereLight"><code
-gui.addColor(new ColorGUIHelper(light, 'color'), 'value').name('color');
+gui.addColor(new ColorGUIHelper(light, 'color'), 'value').name('skyColor');
+gui.addColor(new ColorGUIHelper(light, 'groundColor'), 'value').name('groundColor');
gui.add(light, 'intensity', 0, 2, 0.01);
gui.add(light, 'intensity', 0, 5, 0.01);
</pre>
<p></p><div translate="no" class="threejs_example_container notranslate">
<div><iframe class="threejs_example notranslate" translate="no" style=" " src="/manual/examples/resources/editor.html?url=/manual/examples/lights-hemisphere.html"></iframe></div>
Expand Down Expand Up @@ -202,7 +202,7 @@ <h2 id="-directionallight-"><a href="/docs/#api/ko/lights/DirectionalLight"><cod
<p>이 역시 GUI를 사용해 목표의 위치를 조정할 수 있도록 만들겠습니다.</p>
<pre class="prettyprint showlinemods notranslate lang-js" translate="no">const gui = new GUI();
gui.addColor(new ColorGUIHelper(light, 'color'), 'value').name('color');
gui.add(light, 'intensity', 0, 2, 0.01);
gui.add(light, 'intensity', 0, 5, 0.01);
gui.add(light.target.position, 'x', -10, 10);
gui.add(light.target.position, 'z', -10, 10);
gui.add(light.target.position, 'y', 0, 10);
Expand Down Expand Up @@ -246,7 +246,7 @@ <h2 id="-directionallight-"><a href="/docs/#api/ko/lights/DirectionalLight"><cod

const gui = new GUI();
gui.addColor(new ColorGUIHelper(light, 'color'), 'value').name('color');
gui.add(light, 'intensity', 0, 2, 0.01);
gui.add(light, 'intensity', 0, 5, 0.01);

+makeXYZGUI(gui, light.position, 'position', updateLight);
+makeXYZGUI(gui, light.target.position, 'target', updateLight);
Expand Down Expand Up @@ -297,7 +297,7 @@ <h2 id="-pointlight-"><a href="/docs/#api/ko/lights/PointLight"><code class="not
<p>거리도 조정할 수 있도록 GUI에 추가하겠습니다.</p>
<pre class="prettyprint showlinemods notranslate lang-js" translate="no">const gui = new GUI();
gui.addColor(new ColorGUIHelper(light, 'color'), 'value').name('color');
gui.add(light, 'intensity', 0, 2, 0.01);
gui.add(light, 'intensity', 0, 250, 1);
+gui.add(light, 'distance', 0, 40).onChange(updateLight);

makeXYZGUI(gui, light.position, 'position', updateLight);
Expand Down
10 changes: 5 additions & 5 deletions manual/ru/lights.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ <h2 id="-ambientlight-"><a href="/docs/#api/en/lights/AmbientLight"><code class=
<p>И вот наш код настройки lil-gui</p>
<pre class="prettyprint showlinemods notranslate lang-js" translate="no">const gui = new GUI();
gui.addColor(new ColorGUIHelper(light, 'color'), 'value').name('color');
gui.add(light, 'intensity', 0, 2, 0.01);
gui.add(light, 'intensity', 0, 5, 0.01);
</pre>
<p>И вот результат</p>
<p></p><div translate="no" class="threejs_example_container notranslate">
Expand Down Expand Up @@ -188,7 +188,7 @@ <h2 id="-hemispherelight-"><a href="/docs/#api/en/lights/HemisphereLight"><code
-gui.addColor(new ColorGUIHelper(light, 'color'), 'value').name('color');
+gui.addColor(new ColorGUIHelper(light, 'color'), 'value').name('skyColor');
+gui.addColor(new ColorGUIHelper(light, 'groundColor'), 'value').name('groundColor');
gui.add(light, 'intensity', 0, 2, 0.01);
gui.add(light, 'intensity', 0, 5, 0.01);
</pre>
<p>Результат:</p>
<p></p><div translate="no" class="threejs_example_container notranslate">
Expand Down Expand Up @@ -219,7 +219,7 @@ <h2 id="-directionallight-"><a href="/docs/#api/en/lights/DirectionalLight"><cod
добавляя ее в наш графический интерфейс.</p>
<pre class="prettyprint showlinemods notranslate lang-js" translate="no">const gui = new GUI();
gui.addColor(new ColorGUIHelper(light, 'color'), 'value').name('color');
gui.add(light, 'intensity', 0, 2, 0.01);
gui.add(light, 'intensity', 0, 5, 0.01);
gui.add(light.target.position, 'x', -10, 10);
gui.add(light.target.position, 'z', -10, 10);
gui.add(light.target.position, 'y', 0, 10);
Expand Down Expand Up @@ -265,7 +265,7 @@ <h2 id="-directionallight-"><a href="/docs/#api/en/lights/DirectionalLight"><cod

const gui = new GUI();
gui.addColor(new ColorGUIHelper(light, 'color'), 'value').name('color');
gui.add(light, 'intensity', 0, 2, 0.01);
gui.add(light, 'intensity', 0, 5, 0.01);

+makeXYZGUI(gui, light.position, 'position', updateLight);
+makeXYZGUI(gui, light.target.position, 'target', updateLight);
Expand Down Expand Up @@ -316,7 +316,7 @@ <h2 id="-pointlight-"><a href="/docs/#api/en/lights/PointLight"><code class="not
<p>Давайте настроим графический интерфейс, чтобы мы могли регулировать расстояние.</p>
<pre class="prettyprint showlinemods notranslate lang-js" translate="no">const gui = new GUI();
gui.addColor(new ColorGUIHelper(light, 'color'), 'value').name('color');
gui.add(light, 'intensity', 0, 2, 0.01);
gui.add(light, 'intensity', 0, 250, 1);
+gui.add(light, 'distance', 0, 40).onChange(updateLight);

makeXYZGUI(gui, light.position, 'position', updateLight);
Expand Down
10 changes: 5 additions & 5 deletions manual/zh/lights.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ <h2 id="-ambientlight-">环境光（<a href="/docs/#api/zh/lights/AmbientLight">
<p>以及创建 lil-gui 的代码：</p>
<pre class="prettyprint showlinemods notranslate lang-js" translate="no">const gui = new GUI();
gui.addColor(new ColorGUIHelper(light, 'color'), 'value').name('color');
gui.add(light, 'intensity', 0, 2, 0.01);
gui.add(light, 'intensity', 0, 5, 0.01);
</pre>
<p>结果如下所示：</p>
<p></p><div translate="no" class="threejs_example_container notranslate">
Expand Down Expand Up @@ -154,7 +154,7 @@ <h2 id="-hemispherelight-">半球光（<a href="/docs/#api/zh/lights/HemisphereL
-gui.addColor(new ColorGUIHelper(light, 'color'), 'value').name('color');
+gui.addColor(new ColorGUIHelper(light, 'color'), 'value').name('skyColor');
+gui.addColor(new ColorGUIHelper(light, 'groundColor'), 'value').name('groundColor');
gui.add(light, 'intensity', 0, 2, 0.01);
gui.add(light, 'intensity', 0, 5, 0.01);
</pre>
<p>结果如下：</p>
<p></p><div translate="no" class="threejs_example_container notranslate">
Expand All @@ -179,7 +179,7 @@ <h2 id="-directionallight-">方向光（<a href="/docs/#api/zh/lights/Directiona
<p>下面代码是将目标点坐标属性添加到 <code class="notranslate" translate="no">lil-gui</code>，使得我们可以控制目标位置</p>
<pre class="prettyprint showlinemods notranslate lang-js" translate="no">const gui = new GUI();
gui.addColor(new ColorGUIHelper(light, 'color'), 'value').name('color');
gui.add(light, 'intensity', 0, 2, 0.01);
gui.add(light, 'intensity', 0, 5, 0.01);
gui.add(light.target.position, 'x', -10, 10);
gui.add(light.target.position, 'z', -10, 10);
gui.add(light.target.position, 'y', 0, 10);
Expand Down Expand Up @@ -213,7 +213,7 @@ <h2 id="-directionallight-">方向光（<a href="/docs/#api/zh/lights/Directiona

const gui = new GUI();
gui.addColor(new ColorGUIHelper(light, 'color'), 'value').name('color');
gui.add(light, 'intensity', 0, 2, 0.01);
gui.add(light, 'intensity', 0, 5, 0.01);

+makeXYZGUI(gui, light.position, 'position', updateLight);
+makeXYZGUI(gui, light.target.position, 'target', updateLight);
Expand Down Expand Up @@ -256,7 +256,7 @@ <h2 id="-pointlight-">点光源（<a href="/docs/#api/zh/lights/PointLight"><cod
<p>下面是添加对 distance 参数控制的代码：</p>
<pre class="prettyprint showlinemods notranslate lang-js" translate="no">const gui = new GUI();
gui.addColor(new ColorGUIHelper(light, 'color'), 'value').name('color');
gui.add(light, 'intensity', 0, 2, 0.01);
gui.add(light, 'intensity', 0, 250, 1);
+gui.add(light, 'distance', 0, 40).onChange(updateLight);

makeXYZGUI(gui, light.position, 'position', updateLight);
Expand Down