WebGPURenderer: Reduce memory churn when using chain maps. #30249
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: -
Description
While working at the docs, I've noticed
WebGPURenderer
allocates temporary array objects when using chain maps. Most of the methods using chain maps are executed at least once per frame. To keep the GC overhead to a minimum, we should avoid this kind of object creation whenever possible.This PR ensures modules using a chain map manage their keys array in module scope. This pattern has already been adopted in
RenderObjects
and is now used globally. Besides, at the end of the chain map usage the array is truncated to a length of0
otherwise it would keep references to objects like scenes or cameras. We do something similar inRenderList.finish()
to ensure user created objects can actually GC collected. Setting the array length to0
should still be the fastest way to clear an array in JavaScript.