-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[code-infra] Reuse useReactVersion
script from the monorepo
#13710
[code-infra] Reuse useReactVersion
script from the monorepo
#13710
Conversation
Deploy preview: https://deploy-preview-13710--material-ui-x.netlify.app/ |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
useReactVersion
script from the monorepouseReactVersion
script from the monorepo
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
@@ -89,7 +90,7 @@ | |||
"@mui/internal-markdown": "^1.0.7", | |||
"@mui/internal-test-utils": "^1.0.4", | |||
"@mui/material": "^5.16.2", | |||
"@mui/monorepo": "github:mui/material-ui#0d9333e9f3999d96679a2691e2815296a81475f2", | |||
"@mui/monorepo": "github:mui/material-ui#288863bd2f8681a82c4bfbaf13215b41043bc551", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
We can remove the script once we'll add a bin
to the monorepo package.json
Follow up to #13360
TODO:
useReactVersion
script reusable in other repos material-ui#42828react-17
andreact-next
workflows on the next branch material-ui#42690