[ignore] Try another approach to fix extraneous cci jobs

.circleci/config.yml

@@ -59,13 +59,6 @@ commands:
         description: 'Set to true if you intend to any browser (for example with playwright).'
 
     steps:
-      - run:
-          name: Resolve React version
-          command: |
-            node scripts/useReactVersion.mjs
-            # log a patch for maintainers who want to check out this change
-            git --no-pager diff HEAD
-
       - when:
           condition: << parameters.browsers >>
           steps:
@@ -97,15 +90,19 @@ commands:
             pnpm --version
       - run:
           name: Install js dependencies
+          command: pnpm install
+
+      - run:
+          name: Resolve React version
           command: |
-            echo "React version $REACT_VERSION"
-            if [ $REACT_VERSION == "stable" ];
+            pnpm use-react-version
+            # log a patch for maintainers who want to check out this change
+            git --no-pager diff HEAD
+
+            if [[ $(git --no-pager diff HEAD) != "" ]];
             then
-              echo "pnpm install"
-              pnpm install
-            else
-              echo "pnpm install --no-frozen-lockfile"
-              pnpm install --no-frozen-lockfile
+                echo "pnpm install --no-frozen-lock"
+                pnpm install --no-frozen-lock
             fi
 
       - when:

package.json

@@ -54,6 +54,7 @@
     "test:argos": "node ./scripts/pushArgos.mjs",
     "typescript": "lerna run --no-bail --parallel typescript",
     "typescript:ci": "lerna run --concurrency 3 --no-bail --no-sort typescript",
+    "use-react-version": "node scripts/useReactVersion.mjs",
     "build:codesandbox": "pnpm release:build",
     "install:codesandbox": "pnpm install --no-frozen-lockfile",
     "release:changelog": "node scripts/releaseChangelog.mjs",

scripts/useReactVersion.mjs

@@ -1,109 +1 @@
-/* eslint-disable no-console */
-/**
- * Given the dist tag fetch the corresponding
- * version and make sure this version is used throughout the repository.
- *
- * If you work on this file:
- * WARNING: This script can only use built-in modules since it has to run before
- * `pnpm install`
- */
-import childProcess from 'child_process';
-import fs from 'fs';
-import os from 'os';
-import path from 'path';
-import { promisify } from 'util';
-import { getWorkspaceRoot } from './utils.mjs';
-
-// TODO: reuse the `useReactVersion.mjs` from the monorepo
-
-const exec = promisify(childProcess.exec);
-
-// packages published from the react monorepo using the same version
-const reactPackageNames = ['react', 'react-dom', 'react-is', 'react-test-renderer', 'scheduler'];
-const devDependenciesPackageNames = ['@testing-library/react'];
-
-// if we need to support more versions we will need to add new mapping here
-const additionalVersionsMappings = {
-  17: {
-    '@testing-library/react': '^12.1.0',
-  },
-  19: {},
-};
-
-async function main(version) {
-  if (typeof version !== 'string') {
-    throw new TypeError(`expected version: string but got '${version}'`);
-  }
-
-  if (version === 'stable') {
-    console.log('Nothing to do with stable');
-    return;
-  }
-
-  const packageJsonPath = path.resolve(getWorkspaceRoot(), 'package.json');
-  const packageJson = JSON.parse(fs.readFileSync(packageJsonPath, { encoding: 'utf8' }));
-
-  // the version is something in format: "17.0.0"
-  let majorVersion = null;
-
-  if (version.startsWith('^') || version.startsWith('~') || !Number.isNaN(version.charAt(0))) {
-    majorVersion = version.replace('^', '').replace('~', '').split('.')[0];
-  }
-
-  await Promise.all(
-    reactPackageNames.map(async (reactPackageName) => {
-      const { stdout: versions } = await exec(`npm dist-tag ls ${reactPackageName} ${version}`);
-      const tagMapping = versions.split('\n').find((mapping) => {
-        return mapping.startsWith(`${version}: `);
-      });
-
-      let packageVersion = null;
-
-      if (tagMapping === undefined) {
-        // Some specific version is being requested
-        if (majorVersion) {
-          packageVersion = version;
-          if (reactPackageName === 'scheduler') {
-            // get the scheduler version from the react-dom's dependencies entry
-            const { stdout: reactDOMDependenciesString } = await exec(
-              `npm view --json react-dom@${version} dependencies`,
-            );
-            packageVersion = JSON.parse(reactDOMDependenciesString).scheduler;
-          }
-        } else {
-          throw new Error(`Could not find '${version}' in "${versions}"`);
-        }
-      } else {
-        packageVersion = tagMapping.replace(`${version}: `, '');
-      }
-
-      packageJson.resolutions[reactPackageName] = packageVersion;
-    }),
-  );
-
-  // At this moment all dist tags reference React 18 version, so we don't need
-  // to update these dependencies unless an older version is used, or when the
-  // next/experimental dist tag reference to a future version of React
-  // packageJson.devDependencies['@testing-library/react'] = 'alpha';
-
-  if (majorVersion && additionalVersionsMappings[majorVersion]) {
-    devDependenciesPackageNames.forEach((packageName) => {
-      if (!additionalVersionsMappings[majorVersion][packageName]) {
-        throw new Error(
-          `Version ${majorVersion} does not have version defined for the ${packageName}`,
-        );
-      }
-      packageJson.devDependencies[packageName] =
-        additionalVersionsMappings[majorVersion][packageName];
-    });
-  }
-
-  // add newline for clean diff
-  fs.writeFileSync(packageJsonPath, `${JSON.stringify(packageJson, null, 2)}${os.EOL}`);
-}
-
-const [version = process.env.REACT_VERSION] = process.argv.slice(2);
-main(version).catch((error) => {
-  console.error(error);
-  process.exit(1);
-});
+import '@mui/monorepo/scripts/useReactVersion.mjs';

test/README.md

@@ -4,7 +4,7 @@
 
 You can check integration of different versions of React (for example different [release channels](https://react.dev/community/versioning-policy) or PRs to React) by running the following commands:
 
-1. `node scripts/useReactVersion.mjs <version>`.
+1. `pnpm use-react-version <version>`.
 
    Possible values for `version`: