Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] Update the core dependencies #2109

Closed
wants to merge 1 commit into from
Closed

[core] Update the core dependencies #2109

wants to merge 1 commit into from

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Jul 9, 2021 •
edited
Loading

To help with #2108 (review) cc @DanailH

@oliviertassinari oliviertassinari added the core Infrastructure work going on behind the scenes label Jul 9, 2021
@oliviertassinari
Copy link
Member Author

oliviertassinari commented Jul 9, 2021 •
edited
Loading

Hum, actually, the tests fail:

Material-UI: The key selectLabel provided to the classes prop is not implemented in ForwardRef(TablePagination).
You can only override one of the following: root,toolbar,spacer,caption,selectRoot,select,selectIcon,input,menuItem,actions.

@DanailH How about we close my PR and repurpose #2108 for better support of @material-ui/core@4?

@DanailH
Copy link
Member

DanailH commented Jul 9, 2021

I applied this PR to my PR #2108

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtassone dtassone dtassone approved these changes

Assignees
No one assigned
Labels
core Infrastructure work going on behind the scenes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oliviertassinari @DanailH @dtassone