Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pickers] Do not use instanceOf DateTime in AdapterLuxon #8734

Merged
merged 1 commit into from
Apr 24, 2023

Conversation

flaviendelangle
Copy link
Member

instanceof was causing issues in #8261

See dmtrKovalenko/date-io#639 for context

@flaviendelangle flaviendelangle self-assigned this Apr 24, 2023
@flaviendelangle flaviendelangle added the component: pickers This is the name of the generic UI component, not the React module! label Apr 24, 2023
@mui-bot
Copy link

mui-bot commented Apr 24, 2023

Netlify deploy preview

Netlify deploy preview: https://deploy-preview-8734--material-ui-x.netlify.app/

Updated pages

No updates.

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 685.9 1,245.6 685.9 914 201.07
Sort 100k rows ms 700.6 1,406.3 1,406.3 1,134.46 297.74
Select 100k rows ms 246.2 410.3 372.8 345.9 60.077
Deselect 100k rows ms 155.4 355.4 277.6 257.84 72.529

Generated by 🚫 dangerJS against 3df983f

@flaviendelangle flaviendelangle marked this pull request as ready for review April 24, 2023 10:53
@flaviendelangle flaviendelangle requested a review from LukasTy April 24, 2023 10:53
@flaviendelangle flaviendelangle merged commit aba4549 into mui:master Apr 24, 2023
@flaviendelangle flaviendelangle deleted the luxon-instanceof branch April 24, 2023 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: pickers This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants