Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Fix Date Pickers usage to Title Case #9680

Merged
merged 3 commits into from
Jul 17, 2023
Merged

[docs] Fix Date Pickers usage to Title Case #9680

merged 3 commits into from
Jul 17, 2023

Conversation

richbustos
Copy link
Contributor

@richbustos richbustos commented Jul 14, 2023 •
edited by oliviertassinari
Loading

What?

Updating Date Picker usage to Title Case.
For example, Date picker => Date Picker

Work on #9318

@richbustos richbustos added docs Improvements or additions to the documentation component: pickers This is the name of the generic UI component, not the React module! component: DatePicker The React component. labels Jul 14, 2023
@richbustos richbustos linked an issue Jul 14, 2023 that may be closed by this pull request
[docs] Update Date Pickers usage with Title Case #9318
Closed
This was referenced Jul 14, 2023
Merged
Closed
LukasTy
LukasTy reviewed Jul 14, 2023
View reviewed changes
Copy link
Member

@LukasTy LukasTy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can spot a few other cases where, pickers is spelled with lowercase when searching for date and time pickers.
Maybe we should adjust all the instances? 🤔
Also, the subheading in here should probable be Date and Time Pickers as well? 🤔

@LukasTy LukasTy changed the title [Docs] Update Date Pickers usage to Title Case [docs] Update Date Pickers usage to Title Case Jul 14, 2023
@LukasTy LukasTy removed the component: DatePicker The React component. label Jul 14, 2023
@richbustos
Copy link
Contributor Author

richbustos commented Jul 14, 2023 •
edited
Loading

I can spot a few other cases where, pickers is spelled with lowercase when searching for date and time pickers.
Maybe we should adjust all the instances? 🤔
Also, the subheading in here should probable be Date and Time Pickers as well? 🤔

Ahh, okay. I thought from the issue we just wanted to update titles only ? If not, I’ll update all references. Thanks!

@oliviertassinari oliviertassinari changed the title [docs] Update Date Pickers usage to Title Case [docs] Fix Date Pickers usage to Title Case Jul 14, 2023
@richbustos
Copy link
Contributor Author

@LukasTy Lmk if you see other instances where "Pickers" isn't capitalized.

I updated where I feel made sense. The only files i excluded were the changelogs. Felt like it's not necessary to update those.

@mui-bot
Copy link

mui-bot commented Jul 14, 2023 •
edited
Loading

Netlify deploy preview

Netlify deploy preview: https://deploy-preview-9680--material-ui-x.netlify.app/

Updated pages

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 310.4 506 394.4 401.44 82.231
Sort 100k rows ms 393.3 789 724.7 630.96 169.363
Select 100k rows ms 125.1 209.4 180.8 176.66 29.963
Deselect 100k rows ms 102 201.8 153.3 157.28 35.497

Generated by 🚫 dangerJS against 85feeaa

LukasTy
LukasTy approved these changes Jul 15, 2023
View reviewed changes
Copy link
Member

@LukasTy LukasTy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great! 👍

@richbustos @LukasTy
Update docs/pages/x/api/date-pickers/index.md
85feeaa 
Co-authored-by: Lukas <llukas.tyla@gmail.com>
Signed-off-by: Rich Bustos <92274722+richbustos@users.noreply.github.com>
@richbustos richbustos merged commit 2e38f34 into master Jul 17, 2023
@richbustos richbustos deleted the date-pickers-title-case branch July 17, 2023 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukasTy LukasTy LukasTy approved these changes

@joserodolfofreitas joserodolfofreitas Awaiting requested review from joserodolfofreitas

@oliviertassinari oliviertassinari Awaiting requested review from oliviertassinari

Assignees
No one assigned
Labels
component: pickers This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[docs] Update Date Pickers usage with Title Case
3 participants
@richbustos @mui-bot @LukasTy