Remove stemArrangement property from Slur #28152
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1018,7 +1010,7 @@ void SlurTieLayout::avoidCollisions(SlurSegment* slurSeg, PointF& pp1, PointF& p | |||
| } | |||
| } else if (!slurSeg->isEndPointsEdited()) { | |||
| // In the odd iterations, adjust the end points | |||
| // Slurs steeper than 45° are gently compensated | |||
| // Slurs steeper than 45° are gently compensated | |||
There was a problem hiding this comment.
Wonder what happened here (was it Uncrustify? 😄)
its-not-nice
approved these changes
May 26, 2025
mike-spa
force-pushed
the
removeStemArrangementPropertyFromSlur
branch
from
3fb083a to
73bed13
Compare
miiizen
approved these changes
May 28, 2025
miiizen
requested changes
May 28, 2025
mike-spa
force-pushed
the
removeStemArrangementPropertyFromSlur
branch
from
73bed13 to
1fac9f1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #28151
Everything about this is wrong. This property was created to only work on copy-paste and never gets updated during layout. In this case, it gets copy-pasted from the palette element and results in the slur grip points getting constantly reset (saving-closing-reopening the file fixes it as the property is then forgotten).