-
Notifications
You must be signed in to change notification settings - Fork 11
Conversation
This is based on #30, so that must be merged first. Resulting README: https://github.com/myitcv/gobin/blob/flag_tweaks/README.md |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM modulo a couple of thoughts and suggestions, thanks!
e28706f
to
74f3b77
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Definitely nicer, thanks. I've got a few more suggestions. YMMV :)
25c7231
to
65d168d
Compare
8007c99
to
bbaf6da
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for all those changes. Looks loads nicer, I think. I have a few more thoughts, take 'em or leave 'em :)
d4e50ed
to
f1d4723
Compare
f1d4723
to
0da7e3c
Compare
0da7e3c
to
1dd053e
Compare
1dd053e
to
7f5f9c7
Compare
7f5f9c7
to
01c4015
Compare
fdb88e4
to
ebce41f
Compare
Also drop the definition of "global mode" and "main module mode", instead preferring "by default" and "when -m is provided". These two modes don't really need names. Fixes #28
@rogpeppe thanks for the repeated reviews on this. I'm going to merge because what we have now is significantly better than what's there now. We can make any further tweaks in a later PR. |
Also drop the definition of "global mode" and "main module mode", instead preferring "by default" and "when -m is provided". These two modes don't really need names. Fixes #28
Fixes #28