Skip to content
This repository was archived by the owner on Mar 23, 2021. It is now read-only.

main: tweak flags to be more friendly #32

Merged
merged 1 commit into from
Nov 4, 2018
Merged

main: tweak flags to be more friendly #32

merged 1 commit into from
Nov 4, 2018

Conversation

myitcv
Copy link
Owner

@myitcv myitcv commented Oct 31, 2018

Fixes #28

@myitcv
Copy link
Owner Author

myitcv commented Oct 31, 2018

This is based on #30, so that must be merged first.

Resulting README: https://github.com/myitcv/gobin/blob/flag_tweaks/README.md

Copy link
Collaborator

@rogpeppe rogpeppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo a couple of thoughts and suggestions, thanks!

@myitcv myitcv force-pushed the flag_tweaks branch 2 times, most recently from e28706f to 74f3b77 Compare October 31, 2018 16:33
Copy link
Collaborator

@rogpeppe rogpeppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely nicer, thanks. I've got a few more suggestions. YMMV :)

@myitcv myitcv force-pushed the flag_tweaks branch 4 times, most recently from 25c7231 to 65d168d Compare November 1, 2018 12:25
@myitcv myitcv changed the title main: tweak flags to be more friendly [WIP] main: tweak flags to be more friendly Nov 1, 2018
@myitcv myitcv force-pushed the flag_tweaks branch 7 times, most recently from 8007c99 to bbaf6da Compare November 2, 2018 10:34
@myitcv myitcv mentioned this pull request Nov 2, 2018
Copy link
Collaborator

@rogpeppe rogpeppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all those changes. Looks loads nicer, I think. I have a few more thoughts, take 'em or leave 'em :)

@myitcv myitcv force-pushed the improve_examples branch 2 times, most recently from fdb88e4 to ebce41f Compare November 4, 2018 17:46
@myitcv myitcv changed the title [WIP] main: tweak flags to be more friendly main: tweak flags to be more friendly Nov 4, 2018
@myitcv myitcv changed the base branch from improve_examples to next November 4, 2018 18:56

Verified

This commit was signed with the committer’s verified signature.
myitcv Paul Jolly
Also drop the definition of "global mode" and "main module mode",
instead preferring "by default" and "when -m is provided". These two
modes don't really need names.

Fixes #28
@myitcv
Copy link
Owner Author

myitcv commented Nov 4, 2018

@rogpeppe thanks for the repeated reviews on this. I'm going to merge because what we have now is significantly better than what's there now. We can make any further tweaks in a later PR.

@myitcv myitcv merged commit 7af5911 into next Nov 4, 2018
myitcv added a commit that referenced this pull request Nov 6, 2018
Also drop the definition of "global mode" and "main module mode",
instead preferring "by default" and "when -m is provided". These two
modes don't really need names.

Fixes #28
@myitcv myitcv deleted the flag_tweaks branch November 6, 2018 18:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants