This repository was archived by the owner on Aug 27, 2018. It is now read-only.
Introduce concept of elements as distinct from components #73
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
!! BREAKING CHANGE !!
One of the shortcuts I had taken until this point was to conflate the concept of a component (definition) and an element. This PR introduces the concept of an element. More precise definitions to follow in the wiki, but briefly:
Render
'sThis has the nice side effect of resolving many of the spurious re-
Render
's that were happening.So changes in this PR include:
<div>
HTML element, we no longer declare*Def
component; instead the constructor functions, e.g.react.Div(...)
return an element, in this casereact.DivElement
react.BlessElement
is nowreact.CreateElement
MyCompDef
, requires that methods be declared on the typeMyCompDef
and not*MyCompDef
(docs to follow)myitcv.io/react
Less interesting:
github.com/gopherjs/jsbuiltin