Update erlang.mk
#218
Merged
Update erlang.mk
#218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zuiderkwast
reviewed
Dec 1, 2024
| # Temporary files directory. | ||
|
|
||
| ERLANG_MK_TMP ?= $(CURDIR)/.erlang.mk | ||
| export ERLANG_MK_TMP | ||
|
|
||
| # "erl" command. | ||
|
|
||
| ERL = erl +A0 -noinput -boot start_clean | ||
| ERL = erl -noinput -boot no_dot_erlang -kernel start_distribution false +P 1024 +Q 1024 |
There was a problem hiding this comment.
Does this work with the old OTP versions we claim to support?
There was a problem hiding this comment.
I tested make, make tests, make docs and make dialyze with OTP versions 21+, which is all we now support.
The reason for updating erlang.mk was that with the old version, make dialyze would not run on recent OTP versions because it was using a warning option that was removed at some point, namely race_conditions.
zuiderkwast
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates our 7 years old version of
erlang.mk:) The core modulecore/beam-cacheis now also needed to run tests.