Broken pool.query for 2-arity

[ghost]

Hi! I noticed that the following lines of code have been removed from the pool.query function between v2.3.2 and v2.4.0:

  if (typeof values === 'function') {
    cb = values;
    values = null;
  }

  if (!cb) {
    // Ignore results and errors if no cb supplied; matches connection.query
    cb = function () {};
  }

As a result, in v2.4.0, when I attempt to call pool.query with only two parameters --- a sql query and a callback function, my code breaks.

Was this an intentional change, in which case, I need to use explicit null values when calling the function, or is this something that you can fix? Thanks.

[dougwilson]

The following test functions and calls pool.query with only two values, a sql query and a callback function: https://github.com/felixge/node-mysql/blob/master/test/unit/pool/test-query.js#L9

Can you post the specific code you are using that does not work?

[dougwilson]

It looks like there is a mistake here: https://github.com/felixge/node-mysql/blob/master/lib/Pool.js#L172 where if there is an error getting the connection from the pool it will not work. Is this what is happening to you?

[dougwilson]

OK, I'll assume that's a yes...

[dougwilson]

Please run a npm install felixge/node-mysql and verify if your issue has been fixed.

[ghost]

Yes it has! Thanks for your help.

[dougwilson]

Thanks for verifying :) This fix will be published as 2.4.1 in just a little bit once Travis CI actually tests the change.

[dougwilson]

OK, published as 2.4.1 now.