Fixes #9, by killing the ffmpeg process if it does not exit within 1 second #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JPasterkampRotec
commented
Feb 14, 2025
•
JPasterkampRotec
commented
- Added a editorconfig because this project was written with spaces instead of tabs, so spaces should be enforced in everyone's editor.
- Passing cancellation token into Stream.ReadAsync.
- Killing the ffmpeg process if it will not cancel within 1 second.
Most visual studio installations default to tabs, while the original creator of this solution seems to use spaces. By adding this editor config everyone will automatically use spaces in this solution.
This does not cancel the reading in most cases sadly, but it is good practice to always pass in cancellation tokens.
Since the cancellation token does not stop the Stream.ReadAsync when the inputsource is offline, we manually kill the ffmpeg process after 1 second of lenience. This causes the ReadAsync method to return 0 bytes, allowing the stream to end.
|
I tried linking this pull request to this issue but don't know how |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.