Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(typing): fix DataFrame.sort_values overload match #2109

Merged
merged 1 commit into from
Feb 27, 2025

Conversation

dangotbanned
Copy link
Member

@dangotbanned dangotbanned commented Feb 27, 2025

What type of PR is this? (check all applicable)

  • 💾 Refactor
  • ✨ Feature
  • 🐛 Bug Fix
  • 🔧 Optimization
  • 📝 Documentation
  • ✅ Test
  • 🐳 Other

Related issues

Checklist

  • Code follows style guide (ruff)
  • Tests added
  • Documented the changes

If you have comments or can explain your changes, please do so below

Gets CI passing again https://github.com/narwhals-dev/narwhals/actions/runs/13566402865/job/37920404861?pr=2109

Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @dangotbanned

@MarcoGorelli MarcoGorelli merged commit 746d196 into main Feb 27, 2025
29 of 31 checks passed
@MarcoGorelli MarcoGorelli deleted the fix-sort-values-overload-match branch February 27, 2025 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants