fix: Allow exprs in .filter constraints
#2114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FBruzzesi
commented
Feb 28, 2025
FBruzzesi
added
the
high priority
|
@FBruzzesi the
UpdateIt worked! https://github.com/narwhals-dev/narwhals/actions/runs/13587573984/job/37988075126?pr=2114 |
@FBruzzesi The range wouldn't let me add as a suggestion 😞
dangotbanned
approved these changes
Feb 28, 2025
There was a problem hiding this comment.
Thanks for this @FBruzzesi
Feel free to revert (497dedf) before merging if you prefer the original
Thanks @dangotbanned - I like your approach 🚀🙏🏼 |
FBruzzesi
changed the title
FBruzzesi
changed the title
.filter constraints
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Related issues
df.filter(c=nw.col('a'))gives incorrect result for pandas and unclear error message for duckdb #2112Checklist
If you have comments or can explain your changes, please do so below