Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GPL-3 or MIT? #120

Closed
phishalot opened this issue Nov 16, 2023 · 5 comments · Fixed by #122
Closed

GPL-3 or MIT? #120

phishalot opened this issue Nov 16, 2023 · 5 comments · Fixed by #122

Comments

@phishalot
Copy link

Howdy,

Since there is no GPL-3 license file (but there is a MIT one) in the repo would it make sense to remove the GPL-3 mention?

"license": "(MIT OR GPL-3.0)",

@marcklingen
Copy link
Contributor

+1, we screen for licenses of dependencies and store2 popped up due to the potential GPL-3.0 license even though the project seems to be fully MIT

@marcklingen
Copy link
Contributor

Just found your answers here:

In a lot of ways, specifying both GPL 3 and MIT seems contradictory, but the intent is to offer this under the "do whatever you want, as long as we're not liable" plan so you can use this in any stack, without legal considerations.

Is there a downside to using only "MIT" with your goal in mind? All other dependencies in our projects have only OSS licenses and I'd assume that including "OR GPL" will trigger copy-left alerts for many others as well.

@nbubna
Copy link
Owner

nbubna commented Dec 18, 2023

These are both OSS licenses, and if the option to use this under GPL 3 triggers an alert, then it's a false positive. You may use this under MIT or GPL. I offer both, choose whichever suits you.

@mistercrunch
Copy link

Hello! It's a false positive for us in the Apache Superset community, and probably for everyone using this lib alongside actions/dependency-review-action, and presumable other license checkers. I believe it'll be affecting anyone using a recent react-storybook as well by extension.

My recommendation would be to pick a license and be clear about it. MIT is most permissive, so unclear why anyone would chose GPL3 given the choice.

@nbubna
Copy link
Owner

nbubna commented Feb 14, 2024

Ok. I give.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants