[NOID] Close resources for open readers #620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loveleif
approved these changes
May 8, 2024
| @@ -336,6 +336,7 @@ public long parseXML(Reader input, TerminationGuard terminationGuard) throws XML | |||
| tx.rollback(); | |||
| throw e; | |||
| } finally { | |||
| reader.close(); | |||
There was a problem hiding this comment.
If this call throws an exception we will not call tx.close(). Might not be an issue in this case though, if I remember correctly transactions are closed on commit/rollback anyway.
gem-neo4j
force-pushed
the
dev_close_resources
branch
from
986562f to
ec0f821
Compare
loveleif
reviewed
May 8, 2024
| @@ -337,6 +337,7 @@ public long parseXML(Reader input, TerminationGuard terminationGuard) throws XML | |||
| throw e; | |||
| } finally { | |||
| tx.close(); | |||
| reader.close(); | |||
There was a problem hiding this comment.
If tx.close() fails (and I believe it can under certain circumstances) we won't close the reader now. You can avoid this by using try with resources (try (final var reader = ...) {), or using something like IOUtils.closeAll (from mono repo).
There was a problem hiding this comment.
This reader isn't auto closeable which is why I didn't wrap it in the try, it is just freeing up resources (not closing the file, which I made a part of a try with resources already), maybe it is fine?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reports that the file is being reported as in use after the procedure has been used.