[hPaeYrJX] Fail apoc.warmup.run on non record storage dbs #629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gem-neo4j
reviewed
May 27, 2024
| withSession(conf, session -> { | ||
| RuntimeException e = | ||
| assertThrows(RuntimeException.class, () -> testCall(session, "CALL apoc.warmup.run()", (r) -> {})); | ||
| assertTrue(e.getMessage().contains("Record engine type unsupported")); |
There was a problem hiding this comment.
Didn't you delete this message? 🤔
There was a problem hiding this comment.
Nice catch! I did, I assume this test is not run as part of the github build? 🤔🤔🤔
There was a problem hiding this comment.
No, I made a mistake in withSession...
loveleif
force-pushed
the
warmup-unsupported
branch
from
fbf1a8a to
11314d1
Compare
loveleif
force-pushed
the
warmup-unsupported
branch
from
be046ea to
add32b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.