Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[yVM4sJbH] Dev fix round trip for csv loading #666

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

gem-neo4j
Copy link
Contributor

@gem-neo4j gem-neo4j commented Oct 9, 2024

Long and Double types can be exported but not imported, so this PR allows for them to be imported (if CSV header says prop:long or prop:double for example).

This PR builds on top of #665

@gem-neo4j gem-neo4j changed the title Dev fix round trip for csv loading [yVM4sJbH] Dev fix round trip for csv loading Oct 9, 2024
@gem-neo4j gem-neo4j force-pushed the dev_fix_round_trip_for_csv_loading branch from fd1dabd to 39c3a08 Compare October 14, 2024 05:56
@gem-neo4j gem-neo4j force-pushed the dev_fix_round_trip_for_csv_loading branch from 39c3a08 to 910aedb Compare October 16, 2024 13:21
Copy link
Collaborator

@hvub hvub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

A side note: I am still surprised that apoc.export procedures have a bulkImport option, but

  1. that is not subject of this PR
  2. there may be good reason for it, which I have not investigated
  3. we may not want to change it no matter what

@gem-neo4j
Copy link
Contributor Author

@hvub hehe be prepared for more surprises the deeper you dive into APOC 😆 Anyway, afaik the bulkImport config means that it prepares files in such a way that the user can use them in a bulkImport later, not that it exports them in bulk :)

@gem-neo4j gem-neo4j merged commit 13d4fb7 into dev Oct 17, 2024
11 checks passed
@gem-neo4j gem-neo4j deleted the dev_fix_round_trip_for_csv_loading branch October 17, 2024 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants